Skip to content

Jhrg/chaining msg update - #1440

Merged
jgallagher59701 merged 3 commits into
masterfrom
jhrg/chaining-msg-update
Oct 13, 2026
Merged

jgallagher59701 merged 3 commits into
masterfrom
jhrg/chaining-msg-update

Conversation

@jgallagher59701

@jgallagher59701 jgallagher59701 commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Description

Reference ticket: HYRAX-2284

We return the Service chaining error with CMR tells us it's a 401 and we return 'Service chaining' error messages for other HTTP-related errors that are not service chaining in the sense intended by this message. These message are (or were by me) intended to alert us to an issue in NGAP and should not apply to cases outside of NGAP.

Tasks

  • Ticket exists and is linked in title
  • Tests added/updated
  • Dead code removed
  • No TODOs added

@sonarqubecloud

sonarqubecloud Bot commented Oct 9, 2026

Copy link
Copy Markdown

@sonarqubecloud

sonarqubecloud Bot commented Oct 9, 2026

Copy link
Copy Markdown

@sonarqubecloud

sonarqubecloud Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

@dh-opendap dh-opendap left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all seem reasonable and correct to me.

@jgallagher59701
jgallagher59701 merged commit 5d0982b into master Oct 13, 2026
5 checks passed
@jgallagher59701
jgallagher59701 deleted the jhrg/chaining-msg-update branch October 13, 2026 17:44
@kyang2014

Copy link
Copy Markdown
Collaborator

Looks OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants