Repository navigation
Hyrax 2294 - #1441
Merged
Merged
Hyrax 2294#1441
Conversation
… buffer chunk to the super chunk.
…mrpparray class members to avoid the duplication of calculating the buffer chunk size twice.
…have to calculate the buffer size before hand to determine if we need to switch to the buffer chunk.
…r chunk and buffer chunk information
…nk and buffer chunk queues only once and also add a method to clean up the queue after a variable is done.
…with the deflate filter and the fletcher32 filter is applied at last.
…t applied filter.
… or the super chunk for general cases.
…unk. Also make several parameters as BES keys so that they can be changed as configuration parameters.
kyang2014
marked this pull request as draft
October 12, 2026 21:14
…super chunk size is the same as the buffer chunk size. Clean up the code and update comments etc.
kyang2014
marked this pull request as ready for review
October 13, 2026 20:37
jgallagher59701
approved these changes
Oct 13, 2026
jgallagher59701
left a comment
jgallagher59701
left a comment
Member
There was a problem hiding this comment.
This looks good. Approved. There are few sonarcloud issues that you might look at, but some are too picky. For example, "complexity is 27 instead of 25 or less". I'd ignore that one. Your call on those issues.
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reference ticket: HYRAX-2294
Implement a way to switch from buffer chunk to super chunk based on the number of chunks and the data transfer size.
Highlights:
Tasks