Repository navigation
Fix cmake testPresets filter syntax. - #378
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check |  |
The description explains the syntax issue and the replacement approach, but it omits the required reference ticket and Tasks sections from the repository template. | Add the required Reference ticket entry, include the Tasks checklist, and confirm the relevant checklist items. Add the template title section if the repository requires the full template structure. |
-
Check name Status Explanation Title check The title clearly and concisely identifies the main change: correcting the CMake test preset filter syntax. Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
✨ Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the labels with care,
“Unit” and “integration” are there.
The presets now use a new shape,
While test selection keeps its place.
I hop away, content and neat.
Comment @coderabbitai help to get the list of available commands.
|
To address the pre-commit issue, checkout the README-pre-commit.md. Either you love it or you hate it... The Travis failure might be a Travis issue - sometimes it gets stuck. I restarted the task. |
I usually like pre-commit hooks. I'll check on the readme. But, this case is complaining about a file that's no part of the PR https://github.com/OPENDAP/libdap4/actions/runs/39656215275/job/119417063181?pr=378#step:4:273. Perhaps I could fix that in a different PR and rebase this one? As I don´t like mixing unrelated changes.
Interesting. |
|
#379 fixes the pre-commit problem. |
The specification for the unit/int tests in the cmake presets used an unknown "includeLabel" field. This would cause some tools, like the cmake-tools vscode plugin, to error and not work. The fix is to use the "include"+"label" regex specification to get equivalent functionality.
6bdea5a to
40d3fb0
Compare
|
Fix cmake testPresets filter syntax.
Description
The specification for the unit/int tests in the cmake presets used an unknown "includeLabel" field. This would cause some tools, like the cmake-tools vscode plugin, to error and not work. The fix is to use the "include"+"label" regex specification to get equivalent functionality.