Repository navigation
docs: mvn -Pdocker validate does not produce usable MariaDB init scripts (#962) - #994
Open
ismisepaul wants to merge 1 commit into
Open
ismisepaul wants to merge 1 commit into
ismisepaul wants to merge 1 commit into
Conversation
…ts (#962) AGENTS.md and docs/database-configuration.md said "mvn -Pdocker validate" prepares the docker/mariadb init scripts. validate only copies the SQL files; convert-sql-scripts.sh, which uncomments the DELIMITER lines, is bound to generate-sources. A db image built after validate alone fails on first start with ERROR 1064 at line 181, which the docs blamed only on a stale image cache. Say generate-sources, and list this as a cause. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation corrections match the Maven phase bindings and address the reported issue without changing runtime behavior.
No open issues 🎉
What changed in this PR
Corrects MariaDB initialization guidance for #962 by documenting the Maven phase required to produce usable SQL scripts.
Changes:
- Replaces
mvn -Pdocker validatewithmvn -Pdocker generate-sourcesfor Docker database preparation. - Explains that incomplete SQL conversion, not just stale Docker caches, can cause initialization errors.
- Leaves integration-test preparation unchanged.
| File | Description |
|---|---|
| docs/database-configuration.md | Corrects the SQL conversion command and expands initialization troubleshooting. |
| AGENTS.md | Updates Docker database prerequisites and recovery instructions. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #962.
What
AGENTS.mdanddocs/database-configuration.mdsaidmvn -Pdocker validateprepares thedocker/mariadbinit scripts.validateonly copies the SQL files.convert-sql-scripts.sh, which uncomments theDELIMITERlines, is bound togenerate-sources. An image built aftervalidatealone fails on first start withERROR 1064 (42000) at line 181, which the troubleshooting sections blamed only on a stale image cache.Both files now say
mvn -Pdocker generate-sourcesand list this as a cause of the error. The integration-test preparation step (mvn -Pdocker validate, as in CI) is unchanged: the tests load the SQL themselves.Checked
On a clean
docker/mariadb/target:mvn -Pdocker validate,coreSchema.sqlhas 0 uncommentedDELIMITERlines;mvn -Pdocker generate-sources, it has 119.This is a documentation-only change, so I didn't run the pipeline.
🤖 Generated with Claude Code