fix(accounts): bind media routes to account ownership - #457
Conversation
Obiente previewNC Native · Obiente updates this comment as the preview changes. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
veryCrunchy
changed the title
97516f7 to
22e7218
Compare
8402deb to
09f3f38
Compare
09f3f38 to
412da29
Compare
412da29 to
3a46d39
Compare
…oute-account-ownership
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fbc82c3783
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
veryCrunchy
changed the title
fix(media): prevent duplicate workspace state on full-screen navigation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a7a9811a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "build.gradle.kts": "de2d98f7fce24b2bc67423bb06aa88d251e1458b1fa3c9c9700dbb14289edbf0", | ||
| "gradle.properties": "99c3ee1a9d68a2548830e7dca0cc4b02f4acf408bfc394a0acd55e7865c53739", | ||
| "gradle/libs.versions.toml": "10ef19d481e525d0ad1e94c9a74abe0a4caca6572cf7d2d0dadabfba3974ab5a", | ||
| "gradle/libs.versions.toml": "69ed47ea88842a0097cc7dc5273016d8954e668763618976a9b781efe2915dda", |
There was a problem hiding this comment.
tools/marketing-capture-inputs.txt inventories the entire ui/src/commonMain/kotlin directory, but this manifest refresh omits the newly added AppWorkspaceState.kt from both captureSources and captureSourceHashes. Consequently, verifyCaptureFreshness reports the file as missing and npm run verify:captures:fresh fails, leaving the checked-in screenshot provenance incomplete; regenerate the manifest with the complete discovered source set.
AGENTS.md reference: AGENTS.md:L99-L101
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6ded067a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
veryCrunchy
added
area:photos
1 participant
Discard media navigation when its owning account is removed, so a retired route cannot reopen that account's content after it is re-added. The release fragment classifies this confidentiality fix as security and limits the guarantee to the implemented account-removal boundary.
This is the final integration branch above #456 and includes main's Intel Mac SQLite runtime and packaged-runtime validation changes.
Validation:
No media bytes or server-side protocol contracts change. The aggregate includes the parent cleanup recovery screen. These results describe source and deterministic validation, not a published release or a live-server compatibility claim.