Repository navigation
Skip the Ready to Install page - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Setup showed a Ready to Install page right before installing. It only repeated the choices just made, so it was one more page to tab through for nothing.
DisableReadyPage=yesremoves it.CurPageChangedprocedure makes the button on Select Additional Tasks say Install. That page is now the last one before installing, and it is always shown because the desktop icon task is there. Inno Setup sets every other page's caption itself.Validation
./installer/Build-Installer.ps1 -AllowDirtycompiles the installer.InstallerTestspass.