Repository navigation
Sign releases with Azure Artifact Signing - #87
Merged
Merged
Conversation
Build-Installer.ps1 signs sic.exe right after publish, so the installer and the portable ZIP carry the signed exe, then lets Inno Setup sign the installer and its uninstaller through the "azure" sign tool that sic.iss enables under /DSign. Every signed file must come out Valid, and the appcast is generated after, since its Ed25519 signature covers the installer's bytes. Signing is on whenever installer/signing.json (gitignored; copy signing.example.json) exists; -NoSign skips it, and -Appcast/-Deploy refuse to go out unsigned without it. The company is "Oire Software", as registered and as the certificate names it: drop "SARL" from the installer's publisher, the copyright lines, the About dialog (with its catalogs), LICENSE, README and the local winget manifests. CLAUDE.md describes the signing setup and the one-time Publisher fix the next winget update needs. Closes #86
The UAC prompt shows the description as the program name instead of the file name, and the signature details link to the product site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #86.
Code signing
Build-Installer.ps1signssic.exeright after publish, so the installer and the portable ZIP both carry the signed exe.sic.issturns onSignTool=azureonly under/DSign, which the script passes along with the sign command.Get-AuthenticodeSignature; anything butValidfails the build.installer/signing.jsonexists (gitignored;signing.example.jsonshows its shape).-NoSignskips it;-Appcastand-Deployrefuse to release unsigned unless-NoSignis given.Magick.Native-Q16-x64.dllalready carries ImageMagick's signature and is left alone.Company name
The company is Oire Software, as registered and as the certificate names it. "SARL" is gone from the installer's publisher, the copyright lines, the About dialog and its catalogs, LICENSE, README and the local winget manifests. The manifests already in winget-pkgs still carry it; CLAUDE.md describes the one-time fix for the next winget update.
Tested
build-installer.batruns it):sic.exe, the uninstaller and the setup exe all signed and Valid.-NoSignbuild: compiles, installer unsigned.-Appcast/-Deployrelease run.