ci(python): install Go in the Python client job so the SonarCloud scan runs on develop again - #369
Merged
Merged
Conversation
…ge run can render the test-suite figures Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Author
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The CircleCI "Python client tests" job has failed on every
developcommit sincemake scripts-coveragestarted runningscripts/mkdocs_suite_figures-test.py: itstest_real_tree_renders_into_the_real_pagerenders the figures withgo run ./cmd/doc-counts -site-blocks, and thecimg/pythonexecutor has no Go toolchain (FileNotFoundError: 'go'). Because the "SonarCloud scan" job requires that job, no analysis ofdevelophas been published since, and the branch's quality gate is stuck on stale results.This installs Go 1.25.0 in the
python-testjob through thecircleci/goorb, the same way the Rust client job already does, so the scripts coverage run can render the figures and the scan runs again.How it was verified
go/install+ "Verify Go version" steps ofrust-test.Checklist
make testandmake lintpass locally (n/a: CI config only)