Skip to content

ci(python): install Go in the Python client job so the SonarCloud scan runs on develop again - #369

Merged
HuiJun merged 1 commit into
developfrom
ci/python-job-go-toolchain
Sep 17, 2026
Merged

HuiJun merged 1 commit into
developfrom
ci/python-job-go-toolchain

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

What and why

The CircleCI "Python client tests" job has failed on every develop commit since make scripts-coverage started running scripts/mkdocs_suite_figures-test.py: its test_real_tree_renders_into_the_real_page renders the figures with go run ./cmd/doc-counts -site-blocks, and the cimg/python executor has no Go toolchain (FileNotFoundError: 'go'). Because the "SonarCloud scan" job requires that job, no analysis of develop has been published since, and the branch's quality gate is stuck on stale results.

This installs Go 1.25.0 in the python-test job through the circleci/go orb, the same way the Rust client job already does, so the scripts coverage run can render the figures and the scan runs again.

How it was verified

  • The config parses as YAML; the added steps mirror the existing go/install + "Verify Go version" steps of rust-test.
  • CI on this PR runs the modified job.

Checklist

  • make test and make lint pass locally (n/a: CI config only)
  • Tests added or updated for the change (n/a)
  • Documentation extended where it already covers the surface (n/a)
  • Changelog entry added (n/a: CI only)
  • baselines regenerated (n/a)
  • No internal work-item labels in the body, docs, or changelog

…ge run can render the test-suite figures

Co-Authored-By: jason.han <hanhuijun@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration
devin-ai-integration Bot marked this pull request as ready for review September 17, 2026 07:07

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Devin Review: 1 flag

Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

Devin Review

@HuiJun
HuiJun merged commit 0ab0f52 into develop Sep 17, 2026
12 checks passed
@HuiJun
HuiJun deleted the ci/python-job-go-toolchain branch September 17, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant