Skip to content

chore: triage and fix SonarCloud HIGH-severity issues #51

Description

@nisargabd

SonarCloud reports 151 open issues at HIGH impact severity: https://sonarcloud.io/project/issues?id=OpenAgriNet_network-adapter&impactSeverities=HIGH&issueStatuses=OPEN

Triage and clear them. The bulk is mechanical — 69 shell [ vs [[ lint in install/, 66 Go cognitive-complexity warnings (half of them in _test.go), and 7 duplicated-literal smells.

Two things need care. The 6 GitHub Actions findings are stale: SonarCloud is still analysing ced4555 (2026-08-31) while main is at fc2573e, so those workflows were already deleted. Getting Sonar onto current main is step 0 and will shrink the list on its own.

The 2 go:S5542 AES findings are a real weakness (ECB, no IV, no auth tag) but sit on the Beckn ONIX encryption wire format. Fixing them unilaterally breaks interop with every peer adapter, so they get a separate protocol issue rather than a lint fix.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions