Repository navigation
Conversation
lohedges
temporarily deployed
to
biosimspace-build
November 5, 2026 12:25 — with
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
November 5, 2026 12:25 — with
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
November 5, 2026 12:25 — with
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
November 5, 2026 12:25 — with
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
November 5, 2026 12:25 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #561.
_score_rdkit_mappingspaired every match of molecule0 with every match of molecule1. It checked each resulting mapping for duplicates by scanning a list of dicts, so the cost grew quadratically withmax_scoring_matches. Most matches are permutations of equivalent hydrogens, so drug-sized ligands could take minutes per pair at the default of 1000.Changes, applied to both the main module and the Sandpit copy:
rmsd_alignnow uses a NumPy Kabsch superposition of the mapped atoms rather than a Siremove().align()and per-atom property lookups.rmsd_flex_alignstill usesflexAlign.Checked against
develon the test-suite and OpenFE benchmark ligands, in both directions, with and without a prematch:rmsd_alignandrmsd_flex_aligngive identical ranked mappings.rmsdgives the same mappings and scores, but mappings with exactly equal scores can come out in a different order, because the RMSD is summed in a different order. The best mapping is unchanged.The new
test_score_rdkit_mappingscompares the function with a brute-force reference: every unique mapping from every pair of matches, with prematch filtering, and each aligned score checked against Horn's quaternion method. It fails 6 of its 20 cases with the previous implementation.develinto this branch before issuing this pull request (e.g. by runninggit pull origin devel): [y]