Conversation
Contributor
|
This is not working for windows properly and needs to be fixed. IMHO |
pob220
marked this pull request as draft
September 30, 2026 16:35
Author
Fixed. |
pob220
marked this pull request as ready for review
September 30, 2026 17:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add xGRIB 0.3.4.0 to master: an optional desktop GRIB plugin whose main addition is generating combined weather, wave and current GRIBs directly within OpenCPN. This candidate also includes the Windows icon corrections and subsequent Generate fixes reported in issue #4.
Disable bundled GRIB before enabling xGRIB, then restart OpenCPN. The catalogue entries require plugin API 1.21 and a matching platform ABI; the full suite also compiled against API 1.22.
What xGRIB adds to the standard GRIB workflow
The main addition is integrated GRIB generation. xGRIB retains the familiar timeline, overlays, cursor readouts and download tools, and adds a Generate GRIB dialog which creates a combined environmental forecast for the selected area and time window, then opens the resulting file directly in OpenCPN.
Windows Generate changes
opencpn.log.eccodes.pcis unnecessary.The reported slow dialog opening remains unconfirmed. Construction checkpoints help distinguish remembered offline-XTD inspection from later download/generation delays. Windows debugging instructions cover helper reuse and Visual Studio symbols; replace the release-tag checkout in those instructions with
git switch --detach fdd5330a20bdf53d3cfcfa16e87b2e439a37831afor this revision.The earlier 0.3.4 fixes also correct icon bitmap depth/scaling, rebuild parameter controls after reopening generated output, restore saved toolbar visibility, balance busy cursors, and support desktop resizing. Parameter controls follow the records present in the loaded GRIB.
Master platform scope
The nine proposed production packages are:
Android and native Windows x64 remain alpha-only and are excluded from this master PR. Android stock-production-APK acceptance and native Windows x64 release qualification remain separate.
Source and validation
Fixed source:
fdd5330. The publication source differs only in the CI deployment parameter default.Full release workflow: all 22 platform/API builds passed, together with the Windows dependency job and native OpenCPN 5.14.2 UI gate. The UI gate loaded the plugin, generated/reopened a 10-message test GRIB, exercised Wind and Current selections, and confirmed clean shutdown.
Additional validation:
metadata.xmlmatches each adjacent XML.Machine-readable publication audit (SHA-256
8bff7f5950de7f1bdf4769c7d762431db681109230d079cc799a0a32588e619f).Production repository:
pob220/xgrib-prod. Experimental packages remain inpob220/xgrib-alpha.