Repository navigation
Add initializer-list operator= to VariableLengthArray (#70) - #240
Merged
Merged
Conversation
Like std::vector::operator=(std::initializer_list), replace the contents
with the list while keeping the allocator and max_size(). Both the
general and the packed-bool specializations forward to
assign(std::initializer_list), so the operator shares its guarantees:
storage is reused when it suffices, lists longer than max_size() throw
std::length_error (or truncate with exceptions disabled), and
allocation failure throws std::bad_alloc.
Tests cover growing, shrinking, and clearing against std::vector,
`= {}` selecting the new overload, the returned reference, the logical
maximum, and storage, allocator, and max_size() retention.
Closes #70.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
operator=(std::initializer_list)tocetl::VariableLengthArray, matchingstd::vector::operator=(3).Both the general and the packed-
boolspecializations forward toassign(std::initializer_list)(from #238), so the operator has the same guarantees as that overload:max_size()are kept, and existing storage is reused when it is large enoughmax_size()throwsstd::length_error; with exceptions disabled the list is truncated tomax_size()std::bad_alloc*thisvla = {}now resolves to the new overload and clears the array, the same asstd::vector.Tests
New cases in
test_variable_length_array_assign.cpp, typed overintandbool:std::vectormax_size()Validation
-fno-exceptions)-Wall -Wextra -Werror -Wconversion -Wsign-conversionclang-format19.1.7 fromtoolshed:ts24.4.3(the CI image) reports no changes for either file;git diff --checkis cleanCloses #70.
🤖 Generated with Claude Code