Repository navigation
esp_metadata: include cavl2.h in the ESP-IDF component package - #262
Open
grgevansdwy wants to merge 1 commit into
Open
grgevansdwy wants to merge 1 commit into
grgevansdwy wants to merge 1 commit into
Conversation
pavel-kirienko
approved these changes
Oct 16, 2026
pavel-kirienko
enabled auto-merge (squash)
October 16, 2026 16:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #261
Problem
The
opencyphal/libcanard4.0.0 package on the ESP Component Registry fails to build:esp_metadata/package_esp_component.shcopies files from a hard-coded list. Commit 0fd1d3a (#250, "switch to cavl2") removed the line that copiedlibcanard/_canard_cavl.h, but never added one for the newlib/cavl2/cavl2.h.Change
Add the missing copy step to
esp_metadata/package_esp_component.sh:Testing
Ran
esp_metadata/package_esp_component.shfrom the repo root, then built an ESP-IDF project (target esp32) against the generatedpackage/libcanard. The build succeeds andcavl2.his resolved frominclude/.Note
The already-published 4.0.0 package will stay broken until a new version is published from this script.