Repository navigation
ucsi/v1_2: Fix GET_PD_MESSAGE offsets - #122
Merged
RobertZ2011 merged 1 commit intoOct 27, 2026
Merged
RobertZ2011 merged 1 commit into
RobertZ2011 merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The localized field corrections and updated test vectors are consistent across all three files, with no unresolved findings.
No open issues 🎉
What changed in this PR
This PR corrects the UCSI v1.2 GET_PD_MESSAGE wire layout and aligns existing tests with the corrected encoding.
Changes:
- Expand the message-offset field to eight bits and shift the byte-count and message-type fields accordingly.
- Update encoding, decoding, and invalid-message-type test vectors across the command layers.
| File | Description |
|---|---|
src/ucsi/v1_2/mod.rs |
Update the top-level command encoding fixture. |
src/ucsi/v1_2/lpm/mod.rs |
Update valid and invalid command decoding fixtures. |
src/ucsi/v1_2/lpm/get_pd_message.rs |
Correct bitfield ranges and associated round-trip and validation fixtures. |
Review effort: Balanced
RobertZ2011
marked this pull request as ready for review
October 27, 2026 17:11
RobertZ2011
enabled auto-merge (squash)
October 27, 2026 17:11
RobertZ2011
requested review from
felipebalbi,
jerrysxie,
kurtjd,
tullom and
williampMSFT
October 27, 2026 17:12
tullom
approved these changes
Oct 27, 2026
RobertZ2011
force-pushed
the
fix-get-pd-message-offsets
branch
from
October 27, 2026 17:35
b265f8c to
73c5184
Compare
kurtjd
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.