Repository navigation
Fix AVS RDO bugs - #123
Merged
RobertZ2011 merged 2 commits intoOct 27, 2026
Merged
Fix AVS RDO bugs#123
Conversation
RobertZ2011
force-pushed
the
fix-epr-avs-pdo
branch
from
October 27, 2026 17:35
53472c4 to
5378c40
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
AVS encoding still permits nonzero mandatory-zero voltage bits, and both AVS fixtures preserve that invalid encoding.
1 open issue
What changed in this PR
This PR corrects AVS request handling in the USB Power Delivery code, addressing the voltage scaling and EPR dispatch bugs described in #84 and #85.
Changes:
- Route EPR AVS PDOs through the AVS decoder instead of PPS.
- Use 25 mV units for AVS voltage encoding and decoding.
- Rename SPR round-trip tests and add an EPR AVS round-trip test.
| File | Description |
|---|---|
src/pdo/rdo.rs |
Correct AVS dispatch and voltage scaling, and update round-trip tests. |
Review effort: Balanced
RobertZ2011
force-pushed
the
fix-epr-avs-pdo
branch
from
October 27, 2026 17:57
5378c40 to
14f3b1b
Compare
RobertZ2011
force-pushed
the
fix-epr-avs-pdo
branch
from
October 27, 2026 17:57
14f3b1b to
5e0c909
Compare
RobertZ2011
marked this pull request as ready for review
October 27, 2026 18:00
RobertZ2011
enabled auto-merge (squash)
October 27, 2026 18:00
kurtjd
approved these changes
Oct 27, 2026
tullom
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #84
Closes #85