Repository navigation
Build and publish x86_64 EC test apps - #223
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the changes adding x86_64 Windows test-app builds and publishing alongside ARM64.
No open issues 🎉
What changed in this PR
Adds infrastructure to build and publish x86_64 Windows EC test apps alongside ARM64 binaries, supporting future use with WinVOS on QEMU q35.
Changes:
- Adds the x86_64 Windows MSVC Rust target.
- Applies static CRT linking to all Windows MSVC targets.
- Builds both architectures and publishes separate ZIP assets to the rolling
latestprerelease.
| File | Description |
|---|---|
ec/rust-toolchain.toml |
Adds the x86_64 Windows MSVC target. |
ec/.cargo/config.toml |
Extends static CRT flags to both architectures. |
.github/workflows/build_ec_test.yml |
Adds an architecture matrix and target-specific release archives. |
Review effort: Balanced
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
A designated dependency auditor needs to confirm authorization for the new Tokio publisher-trust entry, which extends safe-to-deploy trust through October 2027 beyond the locked dependency update.
No open issues 🎉
Review effort: Balanced
williampMSFT
approved these changes
Oct 28, 2026
RobertZ2011
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This now builds the EC test apps for
x86_64in addition toaarch64and publishes them on a release alongside the ARM binaries. The motivation is so that these can be used on anx86_64build of WinVOS on the qemu q35 platform.May have to actually modify code for some sources to work on q35 in the future, but this PR's goal is just to get the basic infrastructure in place to support x86.
Note: Includes unrelated commit to bump tokio due to a security advisory (see: OpenDevicePartnership/embedded-services#978). Necessary for CI to pass.