Repository navigation
[NOT-FOR-UPSTREAM, RETIRED] HID: ayaneo: LED-name experiment - #130
Draft
sknowledge1 wants to merge 1 commit into
Draft
sknowledge1 wants to merge 1 commit into
sknowledge1 wants to merge 1 commit into
Conversation
Prepare an OGC-only go:rgb:joystick_rings name for testing if Steam cannot discover the generic AYANEO LED name. Keep effects and controls unchanged. Device evidence is required before deciding whether this compatibility candidate should be used; do not make this name a generic upstream ABI. Assisted-by: Codex:GPT-6
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an OGC-only
go:rgb:joystick_ringscompatibility-name experiment for AYANEO joystick lighting. Private device testing found no Steam controls with either the generic name or this candidate, so it remains unqualified and draft.Only the LED name and its allocation change. Color, brightness, effect attributes, HID commands and Magic Modules behavior remain unchanged. Based on
features/ayaneoatf4471f7a956cadd1f518e87b07b3a06e3bc1e9c9; candidate64fb9d5b9e58290b48b69fed175fd7c35ad846b4.Current path: InputPlumber #734 provides managed native lighting; #735 is closed. OGC #123 already supplies the AYANEO interfaces. This naming patch is not a dependency.
The recorded generic-name and renamed-device tests were both unsuccessful. Retain their evidence without adopting the go-style name as a generic upstream ABI requirement.
Private device test on 2026-10-14: AYANEO 3 8840U, BIOS 1.00, Bazzite 44.20261012.1, kernel 7.2.9-ogc3.1.fc44.x86_64, Steam 1791918634 / steamdeck_stable (Oct 13 updater). The stock generic name did not expose controls in Steam Customization with the effective InputPlumber profile containing no LED entries. Brightness, multi_intensity and effect were writable as the Steam user.
The candidate HID module built against the exact installed kernel headers and loaded successfully, exposing go:rgb:joystick_rings, both module IDs and the same writable attributes. Steam restarted after the load, but the user still saw no joystick lighting controls. Steam logs classify the device as SteamOSGeneric; the root cause of the missing controls remains unresolved. On the restored stock driver, the native LEDManager GetState call succeeds with is_service_available=false and devices=[]. The naming change alone is not demonstrated to solve discovery. The temporary module was unloaded and the packaged stock driver restored. The initial Steam-first pause was superseded by the managed native path in InputPlumber #734. This naming experiment is retired and unqualified; no full kernel/image build or official Bazzite acceptance is claimed.
Assisted-by: Codex:GPT-6