xm-85h50ai: ship the majestic-af autofocus plugin

[widgetii]

Selects BR2_PACKAGE_MAJESTIC_AF=y for the hi3516ev300 85H50AI device, so its
firmware carries the out-of-core autofocus engine
(OpenIPC/majestic-af), compiled from
source by the firmware package.

#142 already enables isp.autofocus on this board through the customizer; with
the plugin present, testers get working autofocus out of the box — the same
engine validated on this exact board (widgetii/majestic#553).

Depends on the firmware package that builds it: OpenIPC/firmware#2357 (must
merge first, or Buildroot drops the unknown BR2_PACKAGE_MAJESTIC_AF symbol).

This board's majestic is the hi3516ev200-family S3 build, which is compiled
WITH_PLUGINS_SUPPORT — so the plugin's HAL seams resolve at dlopen.

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Enable majestic-af for XM 85H50AI firmware

✨ Enhancement ⚙️ Configuration changes 🕐 Less than 5 minutes

AI Description

• Includes the majestic-af engine in XM 85H50AI firmware images.
• Completes the board’s existing autofocus configuration with its required runtime plugin.

High-Level Assessment

The board-specific defconfig is the correct integration point because autofocus is already enabled for this device and the plugin has been validated on its platform. Enabling the package globally would unnecessarily increase unrelated firmware images; merge ordering with OpenIPC/firmware#2357 remains required.

Files changed (1) +1 / -0

Other (1) +1 / -0

hi3516ev300_lite_xm-85h50ai_defconfigInclude majestic-af in XM 85H50AI builds +1/-0

Include majestic-af in XM 85H50AI builds

• Selects the majestic-af Buildroot package for the XM 85H50AI firmware. This supplies the external autofocus engine required by the board’s existing 'isp.autofocus' configuration.

devices/hi3516ev300_lite_xm-85h50ai/br-ext-chip-hisilicon/configs/hi3516ev300_lite_xm-85h50ai_defconfig

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📜 Skill insights (0)

1. Autofocus option is undefined 🐞 Bug ≡ Correctness

Description

The defconfig now requests BR2_PACKAGE_MAJESTIC_AF, but no package or Kconfig definition for that
symbol exists in this branch, so Buildroot cannot select or build the autofocus plugin. A firmware
build from this PR alone therefore still ships without autofocus despite the customizer enabling it.

Code

devices/hi3516ev300_lite_xm-85h50ai/br-ext-chip-hisilicon/configs/hi3516ev300_lite_xm-85h50ai_defconfig[59]

+BR2_PACKAGE_MAJESTIC_AF=y

Evidence

The changed defconfig line is the only occurrence of BR2_PACKAGE_MAJESTIC_AF in this repository,
while the board customizer independently enables autofocus. Thus, without the explicitly mentioned
external package dependency being present at build time, the configuration request has no
implementation to select and the runtime setting has no plugin behind it.

devices/hi3516ev300_lite_xm-85h50ai/br-ext-chip-hisilicon/configs/hi3516ev300_lite_xm-85h50ai_defconfig[56-60]
devices/hi3516ev300_lite_xm-85h50ai/general/overlay/usr/share/openipc/customizer.sh[29-31]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The defconfig enables `BR2_PACKAGE_MAJESTIC_AF`, but this branch contains no definition for that Buildroot symbol. When built before the dependent firmware package is available, Buildroot drops the unknown option and produces firmware without the autofocus plugin while the board customizer still enables autofocus.

## Issue Context
The plugin package must be available in the Buildroot external tree before this defconfig entry can have any effect. Keep the dependency synchronized in the merge/release process, or add the package definition in the same change.

## Fix Focus Areas
- devices/hi3516ev300_lite_xm-85h50ai/br-ext-chip-hisilicon/configs/hi3516ev300_lite_xm-85h50ai_defconfig[59-59]
- package[1-1]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

Context sources

Review mode: 🚀 Fast: This is a single, localized defconfig symbol addition enabling one autofocus package, with no broad logic or high-risk security/data-path changes.

Tip of the day

💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗