Skip to content

[com1]: stopping option for implicit friction; sfcChangeCum output file - #1343

Open
PaulaSp3 wants to merge 3 commits into
masterfrom
PS_stoppingImplicitFric
Open

PaulaSp3 wants to merge 3 commits into
masterfrom
PS_stoppingImplicitFric

Conversation

@PaulaSp3

@PaulaSp3 PaulaSp3 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor
  • when adaptSfcStop = 1 -> stopping occurs when friction is implicit, when velocity magnitude <= 1.2 * minimum velocity value
  • added accumulated sfc change output file

PR Checklist

Please confirm before requesting review:

  • I ran pytest locally without fails
  • I added/updated tests where needed
  • I updated documentation where needed

Confirm before the final merge/rebase into master

  • Commits are sensibly squashed and rebased onto latest master
  • Standardtest run without difference (with recompiled cython code)

@PaulaSp3
PaulaSp3 requested review from awirb and fso42 October 14, 2026 08:59
@PaulaSp3 PaulaSp3 self-assigned this Oct 14, 2026
@qltysh

qltysh Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Analysis for project AvaFrame

❌ 1 blocking issue (1 total)

Tool Category Rule Count
black Style Incorrect formatting, autoformat by running qlty fmt. 1 ❌

@qltysh one-click actions:

  • Auto-fix formatting (qlty fmt && git push)

@qltysh

qltysh Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Qlty


Coverage Impact

This PR will not change total coverage.

Modified Components (1)

RatingComponent% Diff
Coverage rating: C Coverage rating: C
com1DFA75.0%

Modified Files with Diff Coverage (2)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
avaframe/com1DFA/com1DFA.py75.0%3208
Coverage rating: A Coverage rating: A
avaframe/out3Plot/plotUtils.py100.0%
Total92.9%
🤖 Increase coverage with AI coding...
In the `PS_stoppingImplicitFric` branch, add test coverage for this new code:

- `avaframe/com1DFA/com1DFA.py` -- Line 3208

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants