Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lokewate
added this pull request to stack #245
September 28, 2026 07:05
17 tasks
lokewate
force-pushed
the
feat/taskflow-guarded-writes-7-view-and-docs
branch
from
September 28, 2026 08:15
2b5e596 to
0c7c9ac
Compare
lokewate
force-pushed
the
feat/taskflow-guarded-writes-7-view-and-docs
branch
from
September 28, 2026 08:33
0c7c9ac to
7043442
Compare
lokewate
force-pushed
the
feat/taskflow-guarded-writes-7-view-and-docs
branch
from
September 28, 2026 08:35
7043442 to
469fcf1
Compare
lokewate
force-pushed
the
feat/taskflow-guarded-writes-7-view-and-docs
branch
from
September 28, 2026 09:01
469fcf1 to
543a4b4
Compare
lokewate
force-pushed
the
feat/taskflow-guarded-writes-7-view-and-docs
branch
from
September 28, 2026 09:28
543a4b4 to
384990e
Compare
The task view and the list now carry step_id, the step the task is on, and version, the row's seq. A client sends step_id back when it acts, so an action on a view the task has since moved past is rejected as stale, and uses version to keep the newest of several views it fetched. version is read-only and never accepted as input. A view has no actions while the task is ADVANCING. Rewrite the architecture, integration and frontend docs and the README for the model the previous PRs introduced: steps and seq, the four guarded writes and their 0-rows contract, the step-addressed wake-up, the callback token, the completion order, the ADVANCING state, and the schema columns a host table needs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Opt-in via TEMPORAL_TEST_ADDRESS. Runs the TaskManager against a real task workflow with two user-input steps and checks that a submission for an unknown or earlier step is rejected without touching the row, that each step advances the seq, and that the end of the workflow marks the task completed at the next seq and wakes the parent exactly once with the parent's step ID. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
lokewate
force-pushed
the
feat/taskflow-guarded-writes-7-view-and-docs
branch
from
September 28, 2026 09:37
384990e to
83508db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Top of the stack: exposes step ID/version on task views, documents the new Step/Seq/guarded-write model end to end, and adds a real-Temporal e2e test. Merging through here is what actually ships the fix.
Type of Change
Changes Made
TaskView/ZoneViewgain read-onlyStepIDandVersion(=Seq) fields for callers that want to display or poll on the current step.taskflow/docs/architecture.md,integration-guide.md,frontend-guide.md,taskflow/README.md, rootREADME.md,plugin-author-guide.md,template-reference.mdfor the Step/Seq/guarded-write model, including a note on why the engine calls this identityActivationIDwhile TaskManager calls it a Step (see refactor(workflow,taskflow)!: rename TaskDone to CompleteStep, TaskType to PluginType, and SubTask* to Step* (1/8) #237).workflow/README.mdis untouched — it never described this mechanism.ErrStaleStepcomment for clarity.Testing
Full
go test -race ./...across the whole chain; e2e test gated behindTEMPORAL_TEST_ADDRESSlike PR5's.Checklist
Related Issues
N/A
Screenshots/Demo
N/A
Additional Notes
Step 8 of 8 (final) in the
taskflow-guarded-writesstack — see #237 for why this stack exists. Base:feat/taskflow-guarded-writes-6-completion.🤖 Generated with Claude Code