Skip to content

Reuse exact GPU validation on draft promotion - #1007

Merged
bradhilton merged 6 commits into
mainfrom
joshua/ready-gpu-cache-20260928
Sep 28, 2026
Merged

bradhilton merged 6 commits into
mainfrom
joshua/ready-gpu-cache-20260928

Conversation

@bradhilton

@bradhilton bradhilton commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

A draft-to-ready transition currently repeats the full 2x H200 validation even when the pull request's head, base, workflow, and test inputs are unchanged. On ready_for_review, this queries retained Actions metadata and reuses a result only when the same PR, exact workflow path/head, successful overall run, successful Run on 2x H200 job, and an unexpired run-owned artifact naming the exact base SHA all match.

The base-bound artifact is produced by the existing result-upload step after every real validation attempt. New heads, base advances, manual dispatches, absent/expired/ambiguous history, and API failures still run the GPU job. The required trainer-rank-gpu-validation check remains present and fails unless classification succeeds and either that authenticated prior result exists or the new validation succeeds.

Validation:

  • final workflow ran successfully on this PR; its noncritical workflow-only diff correctly skipped the GPU job
  • workflow YAML parses successfully
  • prek passes for the changed workflow
  • git diff --check

No GPU workload was launched while preparing this change.

@bradhilton
bradhilton marked this pull request as ready for review September 28, 2026 10:25
@bradhilton
bradhilton merged commit a49af8b into main Sep 28, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant