Reuse exact GPU validation on draft promotion - #1007
Merged
Merged
Conversation
bradhilton
marked this pull request as ready for review
September 28, 2026 10:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A draft-to-ready transition currently repeats the full 2x H200 validation even when the pull request's head, base, workflow, and test inputs are unchanged. On
ready_for_review, this queries retained Actions metadata and reuses a result only when the same PR, exact workflow path/head, successful overall run, successfulRun on 2x H200job, and an unexpired run-owned artifact naming the exact base SHA all match.The base-bound artifact is produced by the existing result-upload step after every real validation attempt. New heads, base advances, manual dispatches, absent/expired/ambiguous history, and API failures still run the GPU job. The required
trainer-rank-gpu-validationcheck remains present and fails unless classification succeeds and either that authenticated prior result exists or the new validation succeeds.Validation:
prekpasses for the changed workflowgit diff --checkNo GPU workload was launched while preparing this change.