Release source rebinding closures after tokenization - #1011
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful trajectory, trace and group tokenization kept completed source graphs alive until cyclic GC after the caller dropped both the input and result.
_rebind_history_sourcesretained its canonical exchanges through the recursive visitor's self-referencing closure. Clear that closure cell infinally, including when rebinding raises, so unowned graphs release promptly.The public reproduction retained 32 of 32 completed inputs with GC disabled before the change and 0 of 32 afterward. Regression tests cover caller-held inputs/results, canonical source aliases, actual replacement of copied exchanges, repeated calls, callback/error ownership and finalizers that invoke nested rebinding.
Validation: 61 focused lifetime, model and parallel-tokenization tests passed on the production patch; all 21 final lifetime controls passed, including five new cases that fail against the original helper. Changed-file type and Ruff checks passed.
Fixes #1010.