Fix same-head TrainerRank GPU reuse - #1016
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub returned an empty
pull_requestsarray for a successfulpull_requestworkflow run, so promoting ART #999 reran the same 2-H200 validation despite an exact, unexpired run artifact. Match prior runs by the stable fork repository, branch, head SHA, workflow path, and existing exact base-SHA artifact instead; ambiguity and missing identity still fall back to fresh validation.The live duplicate run was cancelled after #999 had merged and its owned pod was verified absent. The changed-head #1000 run was left untouched.
Validation:
2 passedintests/unit/test_trainer_rank_gpu_workflow.pygit diff --check