Repository navigation
test(alarm): arm with WHAT 8, not WHAT 1 (OWNd#66 conformance) - #608
Merged
GreenGrassBlueOcean merged 1 commit intoOct 2, 2026
Conversation
Four alarm tests used *5*1*0## (activation) as "armed away". The F454 trace (OpenWebNet-HA#311) shows WHAT 1 on every disarm (*5*2*0## -> *5*1*0## -> *5*9*0##) and in disarmed status dumps; arming is *5*1*0## -> *5*8*0##. The H4890 (OpenWebNet-HA#466) and MH202 (OpenWebNet-HA#564) captures are disarmed status dumps with no arm transition. OWNd#66 makes is_armed_away WHAT 8 only, which turned these tests red in OWNd's downstream conformance job. The tests now arm with *5*8*0##, and the WHAT 1 case follows whatever the installed OWNd reports, so they pass on OWNd 2.0.0b9 and on OWNd#66. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Oct 2, 2026
Merged
GreenGrassBlueOcean
merged commit Oct 2, 2026
fb3cce9
into
OpenWebNet-HA:v2-phase1-architecture
16 checks passed
gdluck
pushed a commit
to gdluck/HomeAssistant-MyHOME
that referenced
this pull request
Oct 2, 2026
WHO 5 WHAT 1 ("activation") means the system is operational, not armed:
arming goes *5*1 -> *5*8 (engage), as upstream OpenWebNet-HA#608 notes. OWNd <= 2.0.0b9
still counts WHAT 1 as armed_away, so the panel excludes it and stays
disarmed until the engage frame.
start_sending_instant_power without a duration passed None to OWNd; the
sensor now defaults to OWNd's own 65 minutes.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZavKvV3ZxYRP6xDBfhHm
1 task done
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
OWNd#66 (OpenWebNet-HA/OWNd#66) makes
is_armed_awayWHAT 8 (engage) only, and OWNd's downstream "MyHOME test suite" job went red on 4 tests:test_component_alarm.py::TestMyHOMEAlarmEntity::test_handle_eventtest_issue_311.py::test_real_world_trace_replay_issue_311test_issue_466_h4890_trace.py::test_h4890_alarm_trace_replay_and_state_transitionstest_issue_564_mh202_alarm_trace.py::test_mh202_alarm_entity_state_transitionsAll four used
*5*1*0##(WHAT 1, activation) as "armed away". The captures say otherwise:*5*1*0##→*5*8*0##*5*2*0##→*5*1*0##→*5*9*0##*5*9*0##,*5*1*0##, zones*5*1*0##,*5*9*0##(3 ms apart), zonesWHAT 0/1 (maintenance/activation) and WHAT 8/9 (engaged/disengaged) are independent axes in the WHO 5 vocabulary. With WHAT 1 read as armed, every disarm goes DISARMED → ARMED_AWAY → DISARMED.
Changes
Tests only:
*5*8*0##. This passes on both OWNd 2.0.0b9 and OWNd#66.test_handle_eventalso feeds*5*1*0##after a disarm and expects whatever the installed OWNd'sis_armed_awaysays: ARMED_AWAY on b9, DISARMED on OWNd#66.Tests
Merge this before OWNd#66 so OWNd's conformance job (which runs against
v2-phase1-architecture) goes green.🤖 Generated with Claude Code