[GreenGrassBlueOcean]

Summary

MyHOME-side companion to OpenWebNet-HA/OWNd#83, the review follow-up to OWNd#82. Test and fixture changes only; everything passes with the pinned OWNd 2.0.0b9, so this can merge before or after the OWNd release.

1. WHO 25 command parse test (a53ea808)

TestCommandParseRouter::test_who25_dry_contact parsed *25*0*31## and expected an OWNDryContactCommand. WHAT 0 is not a dry contact: dry contacts are WHAT 31 and 32. The test only passed because OWNd's WHO 25 command parser sent every WHAT outside 21–28 to OWNDryContactCommand. OWNd#83 makes the command parser follow the event rule from OWNd#77 fix 9 (only 31/32 are dry contacts), which breaks the test. It now parses *25*31#1*339##, a dry-contact frame captured on the MyHOME#466 plants. MyHOME's own code only builds OWNDryContactCommand.status() (*#25*…##), which does not change.

2. Golden corpus: the same corrections as OWNd#83 (9a07ccf4)

MyHOME keeps its own copy of the golden corpus. These blocks are copied from OWNd#83, and only where MyHOME's block was identical to OWNd's old one:

Fixture	Was	Now	Why
thermo.cmd.mode.antifreeze.zone1	*4*110*1##	*4*102*#1##	110 is manual heating; the firmware forwards nothing for it. The Encyclopedia zone-setup table gives *4*102*#WHERE##.
thermo.cmd.mode.protection.zone1	*4*111*1##	*4*302*#1##	111 is automatic heating. The Encyclopedia gives *4*302*#WHERE##; libqtdevices sends 302 to #zone.
cover.cmd.up.bus.21, cover.cmd.stop.bus.21	21#4#1	21#4#01	The firmware refuses a one-digit interface (au2); Encyclopedia WHO 2: INTERFACE = [0-1][1-9].
dry_contact.event.on.15 → dry_contact.event.on.339	*25*31#1*15##	*25*31#1*339##	H4890 capture. Every captured dry contact has a WHERE that starts with 3.
cen.event.extended_press.btn1.0001	unchanged	notes added	The spec allows WHERE 0001, but bt_luci refuses it; no capture either way.
cen.event.extended_press.btn3.0512 (new)	—	*15*03#3*0512##	MH200N + MyHomeServer1 capture from #624, with OWNCenCommand.start_long_press builder parity.

SOURCE.yaml lists the three captures (#466 H4890, #629 F454, #624). The README and corpus.json follow (184 fixtures). MyHOME's copy already had the #629 central-unit status fix, which OWNd#83 now mirrors.

3. Deprecated central_status() (564d736a)

OWNd#83 deprecates central_status(), which builds *#4*#0*14##, a frame gateways refuse. The thermo.cmd.central.status.cu99.dim14_legacy entry keeps the frame as a record, without its builder block. MyHOME polls the central unit with status("#0") and never called central_status(). The set_central_mode builder blocks OWNd#83 adds to the two zone fixtures are not mirrored yet: with 2.0.0b9 they would build 110/111. They belong with the 2.0.0b10 bump.

Not changed here

• The ("cover.cmd.up.bus.21", "MH200N"): "nack" entry in KNOWN_GATEWAY_DISCREPANCIES (tests/test_firmware_oracle_conformance.py) no longer matches anything: the corrected frame is not in the oracle index. The test ignores it. Removing it would conflict with fix(climate): align central unit mode commands and fan mode with OWNd canonical protocol (OWNd#77) #630, which edits the neighbouring lines.
• docs/protocol_conformance_matrix.md still lists *2*1*21#4#1##; OWNd#82 fix 10 already replaced it in OWNd's copy.

Verification

tests/test_golden_conformance.py, tests/test_firmware_oracle_conformance.py and tests/test_gateway_messages.py:

• OWNd 2.0.0b9 (released): 655 passed.
• OWNd#83 (29040c9): 650 passed, 5 failed, with OWNd deprecation warnings turned into errors. All five are the old-frame tests fix(climate): align central unit mode commands and fan mode with OWNd canonical protocol (OWNd#77) #630 updates (four central-mode builder-parity cases, test_dry_contact_off), none from this PR.

tools/golden/validate_corpus.py: 256 frames valid. git merge-tree against #630's branch: no conflicts.

🤖 Generated with Claude Code

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!