Repository navigation
fix(climate): determine hvac_action from season when active actuator carries no heating flag - #721
Merged
GreenGrassBlueOcean merged 1 commit intoOct 15, 2026
Conversation
…carries no heating flag
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
GreenGrassBlueOcean
deleted the
fix/climate-season-action-determination
branch
October 15, 2026 20:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression in HVAC action determination that caused
test_replay_of_the_fancoil_probeintests/test_f461_live_plant.pyto fail when running against OWNd PR #97 (conformance run 38768716488).Root Cause
Under upcoming OWNd (OpenWebNet-HA/OWNd#94 / OpenWebNet-HA/OWNd#97), WHAT 1/0 are decoded as
hvac_season(MESSAGE_TYPE_SEASON) rather thanhvac_mode. Intests/test_f461_live_plant.py::test_replay_of_the_fancoil_probe, the zone starts in cooling season (*4*0*2##), adoptingHVACMode.COOL, and later switches to heating season (*4*1*2##) with the heating valve on (actuator 1).When actuator status reports arrive for dimension 20 (
*#4*2#2*20*5##),message.is_heating()andmessage.is_cooling()areNone(only dimension 19 setsis_heating).MyHOMEClimatefell back toelif self._attr_hvac_mode == HVACMode.COOL: self._attr_hvac_action = HVACAction.COOLING, reporting cooling action while in heating season with the heating valve open.Changes
custom_components/myhome/climate.py:SEASON_CONDITIONINGalongsideSEASON_HEATING.MESSAGE_TYPE_ACTION, checkself._season == SEASON_HEATING(andSEASON_CONDITIONING) before falling back to_attr_hvac_mode.OWNd==2.0.0b10andOWNdPR 97 (feat/who4-consolidated-heating).