Skip to content

fix(gateway): identify MH201 via empty-WHERE WHO 1013 and include in device type 200 - #722

Merged
GreenGrassBlueOcean merged 1 commit into
v2-phase1-architecturefrom
fix/mh201-gateway-diagnostics
Oct 15, 2026
Merged

GreenGrassBlueOcean merged 1 commit into
v2-phase1-architecturefrom
fix/mh201-gateway-diagnostics

Conversation

@GreenGrassBlueOcean

Copy link
Copy Markdown
Contributor

Summary

Follow-up to OpenWebNet-HA/OWNd#116 review by @fedem95 (5538969896) and companion to OpenWebNet-HA/OWNd#119.

Context & Fixes

  1. Empty-WHERE WHO 1013 Query:

    • MH201 NACKs WHO 1013 Dimension 1 queries with WHERE=0 (*#1013*0*1##), but accepts and answers queries with empty WHERE (*#1013**1##).
    • Updated _request_object_model() in custom_components/myhome/gateway.py to queue *#1013**1##.
  2. MH201 Catalogue & Observed Device Type Mapping:

    • In custom_components/myhome/const.py:
      • Added MH201 to WHO13_OBSERVED_DEVICE_TYPES["200"] (firmware 3.3.6 and 3.6.27 report WHO 13 Dimension 15 code 200). Updated comments clarifying code 200 is shared across modern gateway families and not all are Linux-based.
      • Added "10": ("MH201",) to WHO1013_OBJECT_MODELS corresponding to MH201 catalog responses (*#1013**1*10*15*0*5##).
  3. Test Suite Updates:

    • Added unit test test_mh201_identity_resolution in tests/test_gateway_identification.py.
    • Updated test assertions in tests/test_gateway_identification.py and tests/test_trace_replay.py for the updated observed device type string and empty-WHERE query.

Verification

  • Targeted pytest: 96 passed in 49.05s
  • Home Assistant architectural standards: verify_ha_standards.py passed (all 22 checks, Platinum scale compliant)
  • Documentation anti-drift check: sync_documentation.py --check passed
  • Linting: ruff check passed with 0 violations

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@GreenGrassBlueOcean
GreenGrassBlueOcean merged commit a5f3888 into v2-phase1-architecture Oct 15, 2026
17 checks passed
@GreenGrassBlueOcean
GreenGrassBlueOcean deleted the fix/mh201-gateway-diagnostics branch October 15, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants