Repository navigation
fix(gateway): identify MH201 via empty-WHERE WHO 1013 and include in device type 200 - #722
Merged
GreenGrassBlueOcean merged 1 commit intoOct 15, 2026
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to OpenWebNet-HA/OWNd#116 review by @fedem95 (5538969896) and companion to OpenWebNet-HA/OWNd#119.
Context & Fixes
Empty-WHERE WHO 1013 Query:
WHERE=0(*#1013*0*1##), but accepts and answers queries with empty WHERE (*#1013**1##)._request_object_model()incustom_components/myhome/gateway.pyto queue*#1013**1##.MH201 Catalogue & Observed Device Type Mapping:
custom_components/myhome/const.py:MH201toWHO13_OBSERVED_DEVICE_TYPES["200"](firmware 3.3.6 and 3.6.27 report WHO 13 Dimension 15 code200). Updated comments clarifying code 200 is shared across modern gateway families and not all are Linux-based."10": ("MH201",)toWHO1013_OBJECT_MODELScorresponding to MH201 catalog responses (*#1013**1*10*15*0*5##).Test Suite Updates:
test_mh201_identity_resolutionintests/test_gateway_identification.py.tests/test_gateway_identification.pyandtests/test_trace_replay.pyfor the updated observed device type string and empty-WHERE query.Verification
96 passed in 49.05sverify_ha_standards.pypassed (all 22 checks, Platinum scale compliant)sync_documentation.py --checkpassedruff checkpassed with 0 violations