Repository navigation
fix(services): send status and dimension requests from send_message as requests - #782
Merged
GreenGrassBlueOcean merged 1 commit intoOct 23, 2026
Conversation
…s requests myhome.send_message passed every frame to handler.send(), so a status or dimension request such as *#1*52*5## went out as a command. When the gateway NACKed it (an F454 with a Legrand 067226 at 52 answers with WHERE 0 replies and a NACK, #777), OWNd logged "Could not send message ... Retrying (1)", sent the request a second time and then logged "No more retries" at ERROR. These are the ERRORs in the #777 reporter's first trace; the integration's own startup queries were already sent as status requests and only log the NACK at DEBUG. Status and dimension requests now go through send_status_request(): same queue, status tier, a NACK is final and logged at DEBUG. Commands and dimension writes are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #777 / #781.
Problem
myhome.send_messagepassed every frame tohandler.send(), so a status or dimension request such as*#1*52*5##went out as a command. In the #777 reporter's first trace, the F454 with a Legrand 067226 at 52 answered that request with aWHERE 0reply and a NACK. OWNd then:Could not send message … Retrying (1),No more retriesat ERROR.The integration's own startup queries from the motion sensor (
*#1*52*5##,*#1*52*7##) were never affected. They already go out as status requests, and the reporter's retest shows them logged asGateway rejected status request … (NACK, 0 response(s))at DEBUG.Change
Status and dimension requests from
send_messagenow go throughsend_status_request(), the same path the integration's own queries use:Commands and dimension writes (
*#1*52*#1*150*5##) still go throughsend().Testing
tests/test_send_message_status_requests.py(new):send_status_requestsendtests/test_f461_live_plant.pyalso pass against the released OWNd 2.0.0b11 pin.verify_ha_standards.pyandsync_documentation.py --checkare clean.test_command_session_send_immediate_status_nack_is_finalcovers the "NACKed status request is final, logged at DEBUG" behaviour this relies on.🤖 Generated with Claude Code