Repository navigation
Coupling to containerised LPJmL - #19
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
- Coverage 78.80% 75.32% -3.48%
==========================================
Files 7 7
Lines 1684 1836 +152
==========================================
+ Hits 1327 1383 +56
- Misses 357 453 +96 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sieben-gea
force-pushed
the
s_container
branch
3 times, most recently
from
September 1, 2026 11:49
bb6e3aa to
cbf2057
Compare
The coupler tests did not test the coupler, but in fact just asserted themselves. I disabled them until we implement better testing with a mocked socket
sieben-gea
force-pushed
the
s_container
branch
from
September 9, 2026 16:28
cbf2057 to
88b07c4
Compare
sieben-gea
force-pushed
the
s_container
branch
from
September 10, 2026 07:46
88b07c4 to
b700669
Compare
These changes add support for the new way of reading metadata in higher versions of LPJmL, but are desighned to be backwards compatible.
sieben-gea
marked this pull request as ready for review
September 17, 2026 14:26
sieben-gea
force-pushed
the
s_container
branch
from
September 17, 2026 14:28
d48f3ca to
3e2ee96
Compare
sieben-gea
changed the title
jnnsbrr
requested changes
Sep 21, 2026
jnnsbrr
left a comment
jnnsbrr
left a comment
Collaborator
There was a problem hiding this comment.
One thing to change, otherwise looks good!
sieben-gea
force-pushed
the
s_container
branch
2 times, most recently
from
October 1, 2026 12:49
71590ae to
6fa97a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request combines changes needed to couple to LPJmL when run from a container by setting the necessary environment variables and using lpjml executables from the
PATHinstead of a specific directory.Changes
submit_lpjml()does writes the coupling command into the SLURM script directly and does not create a separate runscriptmetaas an input formatPATH. It also expects an environment variableLPJML_CONTAINERto be set.Bugfix
model_pathdoes not need to be set and is now fully optional.Deprecations
run_lpjml()has been deprecated, useoperate_lpjml(wait_for_exit=True)instead.Breaking changes
config.versionshould be set to the actual version of the running LPJmL.config.inpathor the environment variableLPJINPATHneeds to be set.check_lpjml()only outputs to stdout in case of an error