feat(native): add SFTP client API - #426
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #426 +/- ##
==========================================
- Coverage 99.53% 99.43% -0.10%
==========================================
Files 18 19 +1
Lines 1703 1764 +61
==========================================
+ Hits 1695 1754 +59
- Misses 8 10 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pkittenis
left a comment
There was a problem hiding this comment.
Looks good as a first pass.
Would need to add a ParallelSFTPClient support for parallel operations, but for a single host SFTPClient this looks good.
Thank you for the PR, some minor changes needed for clarity and future parallel support.
|
Would suggest just implementing a single host The parallel client I will take on as a separate PR once the single host client is merged. |
|
Thanks for the guidance. I updated this PR to keep the single-host |
|
|
||
| _make_sftp = make_sftp_client | ||
|
|
||
| def open_sftp(self): |
There was a problem hiding this comment.
Please call this function make_sftp_client to make it explicit.
| def open_sftp(self): | |
| def make_sftp_client(self): |
| return self.eagain(self.session.sftp_init) | ||
|
|
||
| def _make_sftp(self): | ||
| def make_sftp_client(self): |
There was a problem hiding this comment.
| def make_sftp_client(self): | |
| def _make_sftp(self): |
No change needed.
Summary
SFTPClientopened throughSSHClient.open_sftp()SSHClientSFTP methods compatible and document native-only supportVerification
flake8 pssh tests ci/integration_testsorigin/master: no new failuresCloses #410.