Repository navigation
Skip linear mosaic targets in ImagingChunkedHandler - #413
Open
thomaswilliamsastro wants to merge 1 commit into
Open
thomaswilliamsastro wants to merge 1 commit into
thomaswilliamsastro wants to merge 1 commit into
Conversation
thomaswilliamsastro
force-pushed
the
chunked-imaging-skip-mosaics
branch
from
October 15, 2026 09:05
82f9f73 to
cf2841a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #413 +/- ##
==========================================
+ Coverage 7.96% 12.63% +4.67%
==========================================
Files 42 43 +1
Lines 16631 16696 +65
Branches 3982 3986 +4
==========================================
+ Hits 1324 2110 +786
+ Misses 15284 14352 -932
- Partials 23 234 +211
|
Mosaic targets have no MS of their own, so ImagingChunkedHandler crashed on init. Check for a linmos target up front, log a warning, and make run_imaging and task_complete_gather_into_cubes no-ops, matching the behaviour of the standard ImagingHandler. Closes #350 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thomaswilliamsastro
force-pushed
the
chunked-imaging-skip-mosaics
branch
from
October 21, 2026 08:05
cf2841a to
ed7ccf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #350.
ImagingChunkedHandlercrashed when given a linear mosaic target, since there's no MS to read. The standardImagingHandlerskips these gracefully.is_target_linmosnear the top of__init__. For a mosaic, log a warning, setskip_target = True,chunk_params = {},nchunks = 0, and return before anything touches the MS. Loops overrange(nchunks)(as in the example script) then just do nothing.run_imagingandtask_complete_gather_into_cubesreturn early with a warning whenskip_targetis set.tests/test_handlerImagingChunked.py, which builds minimal keys with a mosaic target and checks the handler skips it. It passes with the fix and fails on the old code (TypeError: cannot unpack non-iterable NoneType objectduring cell/imsize setup).Note: a missing MS for a non-mosaic target still crashes; the standard handler skips that case too, but it's out of scope here.
🤖 Generated with Claude Code