Repository navigation
Conversation
…start Adds a bookings.booking_reminder template trigger plus a scheduled sweep that emails the booking owner ahead of the booking starting. Reminders are configured as a list of offsets in minutes before the start, checked by a cron sweep, since a cron entry alone cannot express "3 days before an arbitrary booking start". A grace window stops stale reminders being sent after downtime, bookings created after their reminder moment and checked-in bookings are skipped, and each reminder is sent once with the state persisted in the driver status.
…overage - resolve the zone attachments and approver merge fields for reminders, honouring disable_attachments, so no placeholder is left unsubstituted - skip zones without notify_booking_owner and bookings with no owner email - drop network_username / network_password from the reminder trigger's advertised fields - a reminder must not rotate the booking's credential - sweep immediately when the driver starts or its settings change, so a restart cannot push a reminder past reminder_grace_minutes - spec: cron driven sweep, two offsets on one booking, a locker booking, and the advertised fields must equal the args actually sent
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
bookings.booking_remindertemplate trigger to the booking notifier, plus a scheduled sweep that emails the booking owner ahead of a booking starting.Reminders are configured as a list of offsets in minutes before the start (
reminders_before_booking), checked on a cron sweep (reminder_schedule), because a cron entry alone cannot express "3 days before a booking that starts on an arbitrary day". A grace window (reminder_grace_minutes) stops a reminder going out late after downtime.Behaviour
user_email), replies go tobooked_by_email. A zone withoutnotify_booking_owner: truegets no reminders.reminders_sentstatus, so a restart does not re-send.booking_type(deploy one instance per type); for a visitor bookinguser_emailis the host. Withunique_templates: truethe trigger becomesbookings.booking_reminder_<booking_type>.attachmentsare resolved the way booking notifications do, honouringdisable_attachments, andattachment_name/attachment_urlare always offered as merge fields.network_username/network_password- a reminder must not rotate the credential the booking email already handed out.reminder_grace_minutes.Testing
./harness report drivers/place/booking_notifier.crand thedrivers/place/*run both pass for this driver:execreminder_offset_minutes%{...}can survive into a concierge-authored templateSupersedes #637.