feat(outlook-addin): calendar pane for rooms and desks, and Teams tab by MrYuion · Pull Request #503 · PlaceOS/user-interfaces

MrYuion · 2026-09-30T08:14:18Z

Problem

The Outlook add-in did not use the open calendar event. It asked for the title, date and time again, and booked rooms by creating a second event through PlaceOS. It had no map, and the workplace app could not open in Teams or the Outlook app bar. The PlaceOS Outlook and Teams development brief (goals G01–G09) asks for all of these.

Solution

Outlook calendar pane (apps/outlook-addin/src/app/calendar/)

Reads the subject, start, end, All day flag, recurrence and rooms from the Outlook item. It reads them again on Outlook change events, on focus, from a refresh button, and before it saves anything. It never infers All day from the duration. It uses the Office.js preview flag when the client has it. Otherwise it uses the saved event from PlaceOS when the saved times match Outlook.
Rooms: "Add to meeting" adds the room with enhancedLocation (type Room), so Exchange books it on Send. The pane shows each room as added, pending, confirmed or declined.
Desks: "Add to event" saves a new event (Outlook sends no invitation), reserves the desk through BookingFormService, and links the booking and the event in both directions. The pane flags the desk when the event time changes and offers Update and Remove. Recurring events and multi-day all-day events are blocked with a message until the policy is agreed.
List and map views for each tab. Filters apply in the pane, so a filter change does not start a new availability request. space-map and desk-map get an optional available input for the filtered list, and both are exported from their libraries.
The manifest has one "PlaceOS" button that opens #/calendar, and it requires Mailbox 1.8. The old forms stay in place for now.
Mock mode now registers the shared mocks in the add-in.

Parking (apps/outlook-addin/src/app/calendar/parking-search.component.ts)

A Parking tab books a parking space or sends a parking request for the event time. The features setting turns on each option (parking and parking-requests). With neither, the tab is hidden.
A parking request is a parking booking with no space. The parking team assigns a space later.
Desks and parking share one booking link service, so parking links to the event the same way as desks. Each type keeps its booking ID in its own item custom property.
The plate number starts with the saved plate number. It is required when parking.require_plate_number is on.
When the booking rules block more parking for a user with an assigned space, the tab shows the assigned space.
Parking has a list view only. The workplace request types (shifts, space restrictions) are not in the add-in.

Workplace as a Teams / Microsoft 365 personal tab

@microsoft/teams-js loads only when the tab URL has ?host=teams. Sign in tries Teams SSO, then a sign-in window, then a Sign in button.
apps/workplace/teams/ has the manifest template, icons and a packaging script. See docs/teams-app.md.

Verification

Tests: outlook-addin 37, workplace 421, events 240, bookings 435, common 376. All pass.
Production builds of outlook-addin and workplace pass.
Checked in the browser in mock mode: room and desk search, filters, map selection, adding a room and reserving a desk. For parking: the space list, a parking request linked to the event, and the assigned-space message.

Not verified yet

Nothing has been run in real Outlook (Classic or New) or in Teams. This needs a test tenant.
index.html loads the production Office.js (lib/1), which has no preview APIs. In production the All day flag comes only from the saved event.
Backend and infrastructure work: PlaceOS must accept the Entra token exchange (RFC 8693) for Teams and Outlook SSO. Without it, sign in falls back to the sign-in window. The host must also allow Microsoft 365 framing (CSP frame-ancestors). Desk and parking bookings whose event is deleted need a cleanup job.
The manifest has no pinning support yet and still points at microsoft.poc.placeos.com.

Changes made by Claude Opus 5.5 (1M context) in Claude Code.

🤖 Generated with Claude Code

vercel · 2026-09-30T08:14:23Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
frontend-templates	Ignored	Preview	Oct 8, 2026 11:45am UTC

greptile-apps

Your trial has ended. Reactivate Greptile to resume code reviews.

vercel · 2026-10-01T02:26:18Z

Deployment failed for project frontend-templates with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/placeos?upgradeToPro=build-rate-limit

greptile-apps

Your trial has ended. Reactivate Greptile to resume code reviews.

greptile-apps · 2026-10-01T06:01:49Z

Confidence Score: 2/5

[Medium risk] Rebuilds Outlook add-in with new calendar booking UI and Teams app support.

The PR is not ready to merge because desk bookings can use old event times, lose their Outlook link, or act on the previous event.

Findings

Desk booked for old time ▶
Desk stays reserved after error ▶
Previous event’s desk persists ▶
Map offers outdated desk ▶

Summary

The Outlook add-in now uses the open appointment to find and add rooms or desks, while Workplace can open as a personal tab in Teams and Microsoft 365.

Rooms join the Outlook invitation; desks get a linked PlaceOS booking.
Both searches add filtered map views, and Teams sign-in can fall back to a sign-in window.
Outlook and Teams gain host-specific app packages and sign-in setup.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Outlook event] --> B[Calendar pane]
  B --> C[Add room to Outlook item]
  B --> D[Save event and reserve desk]
  D --> E[Write booking ID to Outlook item]
  T[Teams tab] --> S[Teams sign-in]
  S --> W[Workplace]

_{Reviews (1) · Last reviewed commit: "feat(auth): exchange Entra tokens for Pl..."}

greptile-apps · 2026-10-01T06:01:58Z

+            this._error.set(
+                errorMessage(error) || 'Unable to read the Outlook event.',
+            );
+            return this._event();


Desk booked for old time

If Outlook fails to read an appointment after its time changes, refresh() returns the previous event. DeskLinkService._post() treats it as a fresh read and can reserve or update a desk for the old time. A failed read should stop the booking instead.

Fixed in 8fd207f. refresh() now returns null when Outlook cannot read the item. DeskLinkService._post() then stops and shows the read error. A refresh that a newer refresh overtakes also returns its own new read, not the old state.

greptile-apps · 2026-10-01T06:01:58Z

+                    ...(saved?.ical_uid ? { ical_uid: saved.ical_uid } : {}),
+                },
+            }).catch(() => booking);
+            await this._outlook.setProperty(DESK_BOOKING_PROPERTY, linked.id);


Desk stays reserved after error

add() creates the desk booking before saving its ID on the Outlook item. If that save fails, the pane reports an error but leaves the desk reserved. When reopened, it cannot find the booking through the missing link. Roll back the booking or make the link recoverable.

Fixed in 8fd207f. When Outlook cannot store the booking ID on the item, add() cancels the new booking and shows the error. No booking stays reserved without a link.

greptile-apps · 2026-10-01T06:01:58Z

+
+    constructor() {
+        this._form.newForm('desk');
+        this.link.load();


Previous event’s desk persists

When a pinned pane moves to another Outlook item, the event refreshes but the desk booking is not reloaded. The desk tab can show the previous appointment’s booking, and Remove or Update can act on it. Reload the desk link when the item changes.

Fixed in 8fd207f. The event service has an item_version signal that changes on ItemChanged. The linked booking belongs to one item version, so it disappears as soon as the item changes, and Remove or Update cannot act on it. The desk search then loads the link for the new item. The adapter also adds the item event handlers again for the new item.

greptile-apps · 2026-10-01T06:01:58Z

+                        [available]="map_desks()"
+                        (onSelect)="selected_desk.set($event)"
+                    />
+                    @if (selected_desk(); as desk) {


Map offers outdated desk

When the event time or available desks change, the map keeps showing selected_desk even if it is no longer in map_desks(). Its card still says “Available” and offers Add. Clear the selection when that desk leaves the available list so users do not try to book an outdated result.

Fixed in 8fd207f. The map card and map highlight now use map_selection(), which shows the selected desk only while it is in map_desks(). If the desk becomes available again, the selection shows again.

Load teams-js only when the tab URL has `?host=teams`. Sign in through Teams SSO, then a sign-in window, then a Sign in button, because the Microsoft login page cannot load in the host frame. Add the app package template, a packaging script and docs/teams-app.md.

Add a task pane that reads the title, time and All day setting from the open Outlook event instead of asking for them again. - Rooms are added to the event as Exchange room resources, so Exchange books them when the invitation is sent. This replaces the old flow that created a second event. - Desks are reserved on "Add to event" and linked to the saved event in both directions. The pane flags a desk when the event time changes. - Each tab has list and map views. Filters apply in the pane, so a filter change does not start a new availability request. - space-map and desk-map accept an optional filtered list and are exported from their libraries. - The manifest has one PlaceOS button that opens the pane.

Replace the legacy Office SSO (getAccessToken) with nested app authentication through MSAL. The PlaceOS sign-in dialog stays as the fallback when the manifest has no client ID or Outlook does not support NestedAppAuth 1.1. The token scope is the same as the Teams app, so one Entra app registration serves both. - manifest.xml is now a template. manifest.ts makes the manifest for a PlaceOS host and adds the Entra client ID to the task pane URL. - The base rule matches the appointment organizer button. Remove AppDomains, FunctionFile and WebApplicationInfo. - Remove the Yeoman scaffold, the function file, ms-auth-login.html, the unused ms-auth route and the IE compatibility meta tag. - Uploads now start when a stored token is used.

Update ts-client to 6.8.0. The Outlook add-in and the Teams tab now exchange the Microsoft Entra SSO token for PlaceOS tokens (RFC 8693) instead of sending it as the bearer token. The exchange gives a refresh token, so the PlaceOS token renews. When the exchange fails, sign in falls back to the sign-in dialog or window.

- Stop a desk booking when Outlook cannot read the event, so it never uses old times. - Cancel a new desk booking when Outlook cannot store its link. - Hide and reload the linked desk when a pinned pane moves to a different item. - Add the item change handlers again after the item changes. - Hide a map selection when the desk is no longer available. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Add a Parking tab that books a parking space or sends a parking request for the Outlook event. The `features` setting turns on each option (`parking` and `parking-requests`). The tab is hidden when neither is on. - Desks and parking share one booking link service. Each type keeps its booking ID in its own item custom property. - A parking request is a parking booking with no space. The parking team assigns a space later. - The plate number starts with the saved plate number and is required when `parking.require_plate_number` is on. - The tab shows an assigned space up front when the booking rules block more parking for the user. - The "On this event" card is a shared component. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

greptile-apps Bot reviewed Sep 30, 2026

View reviewed changes

greptile-apps Bot reviewed Oct 1, 2026

View reviewed changes

MrYuion and others added 5 commits October 8, 2026 22:13

MrYuion force-pushed the feat/outlook-calendar-pane branch from 95da5d0 to a4af0e5 Compare October 8, 2026 11:15

Conversation

MrYuion commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Verification

Not verified yet

Uh oh!

vercel Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

vercel Bot commented Oct 1, 2026

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 2/5

Findings

Summary

Uh oh!

greptile-apps Bot Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

MrYuion Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

MrYuion Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

MrYuion Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

MrYuion Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

MrYuion commented Sep 30, 2026 •

edited

Loading

vercel Bot commented Sep 30, 2026 •

edited

Loading

greptile-apps Bot commented Oct 1, 2026 •

edited

Loading