fix(bookings): store the flow type on a quick-book booking

[camreeves]

What was broken

The home page desk tile (app.show_quick_book) created a booking whose booking_type was a single space, which staff-api stored as "":

{"booking_type":"","asset_id":"e2e-desk-0","title":"Booking", ...}

Booking defaults a missing type to ' ', and postForm only fell back to the flow's type when the model's type was falsy. A space is truthy, so the fallback never ran. An untyped booking is invisible to the desk listing and is skipped by staff-api's clash check, so the desk can be double-booked.

Found by the #497 e2e spec HOME-09, which asserts on the stored booking_type.

Change

• newForm sets the flow type on an untyped form. Quick-book and any other caller that does not set the type now get a typed form, and validators that depend on the type (parking plate number, visitor email) run.
• loadForm(type) sets the flow type on an untyped stored booking. Before, the desk and parking flows saw a type mismatch and replaced the booking with a new form.
• postForm sets the type before validation, not after.
• isCrossTypeEdit treats ' ' as no type. Before, an untyped booking (as made by this bug) was discarded when opened for editing, and saving made a duplicate.
• One _formBookingType() helper replaces the two different blank-type checks.
• BookingFormValue.booking_type is BookingType, not any. knownBookingType returns a type without the blank ' '.

Unit tests cover the desk type, parking validation, an untyped postForm, an untyped loadForm, and the untyped edit. Each new postForm/loadForm test fails without its fix.

HOME-09 passed against the first commit. I did not run it again on the final head: the e2e Docker stack was not available.

---

Changes by Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

[vercel]

Deployment failed for project frontend-templates with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/placeos?upgradeToPro=build-rate-limit

[MrYuion]

The fix is correct for quick-book and the other untyped newForm(type) callers. I found no blocking bugs. I found one test gap and three smaller items.

I ran the bookings test target on booking-form.service.spec.ts at 34cf6bfb6. The three new tests pass, and the full file passes.

1. No test covers the postForm change (libs/bookings/src/lib/booking-form.service.ts:1328)

The description says the postForm patch covers forms that loadForm restores. All three new tests start from newForm, and newForm already sets the type at line 970. If you remove the line-1328 patch, all three tests still pass. Nothing tests the loadForm path.

Suggested test: make an untyped form, then post it.

spectator.service.newForm('desk');
spectator.service.model.update((m) => ({ ...m, booking_type: ' ', asset_id: 'desk-1', /* date, duration */ }));
await spectator.service.postForm(true);
expect((savedBookings()[0] as Booking).booking_type).toBe('desk');

A loadForm('desk') case with an untyped form in sessionStorage also works.

2. The isCrossTypeEdit change does not keep an untyped booking in the workplace edit flow (booking-form.service.ts:237)

The description says that, before this PR, opening an untyped booking for edit discarded it and saving made a duplicate. The new test covers newForm('desk', booking). The workplace edit path is different:

1. schedule.component.ts:289 and landing-upcoming.component.ts:160 call newForm(event.booking_type, event). For an untyped booking, the type is ' ', so the form type stays ' '.
2. desk-flow.component.ts:69 (and parking-flow.component.ts:134) then runs if (!id || booking_type !== 'desk') this._state.newForm('desk'). This clears the booking.

I ran this sequence in a temporary spec. The form id was '' after the flow ran. The schedule queries bookings by type, so an untyped booking probably never gets to this path. If that is correct, the change is safe but has no effect for these callers. Please change the description so it does not say more than the code does. If you want a full fix, also let loadForm(expected_type) set the type (knownBookingType(model.booking_type) || expected_type).

3. booking_type is still any in the form model (libs/bookings/src/lib/booking.utilities.ts:195)

BookingFormValue.booking_type is any. Thus knownBookingType(this.model().booking_type) gets no type check. Also, BookingType includes ' ', so _formBookingType(): BookingType can return ' ' when _options().type is ' ', for example after newForm(event.booking_type, event). Optional: type the field as BookingType | '', and let knownBookingType return Exclude<BookingType, ' '> | undefined with an explicit type && type !== ' ' check. Then the compiler finds the blank-type case.

4. Run HOME-09 again on the final head

The description says that HOME-09 passed on the first commit only. The second commit moved the fix into newForm. Please run HOME-09 again on 34cf6bfb6 before merge.

Review by Claude Opus 5.5 in Claude Code (T3 Code).

[camreeves]

HOME-09 re-run on 0797407: passes (the desk tile books after confirmation and the backend stores booking_type: desk), against an e2e stack built from develop at 73af7f6 with this branch merged in. That was the one item left on this one.