Repository navigation
fix(concierge): name the locker on the locker bookings listing - #552
Merged
Merged
Conversation
A booking stores the locker's id only (the Booking model has no asset name column; the name sent on create never comes back), so the Locker column showed `asset-...`. The listing now resolves the name from the lockers the state has already loaded for the building, the way the desk listing resolves desk names, and falls back to the id for a locker it does not know.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
camreeves
added a commit
that referenced
this pull request
Oct 7, 2026
… tenant CON-B1 loses its guard: concierge now admits admin and support users only until app.allow_access_groups is set (develop, #551), so a plain staff user lands on /unauthorised. The test waits for that bounce or the shell, whichever comes first. CON-B3 asserts what can be true: a booking has no asset name column, so the listing resolves the locker's name from the lockers it has loaded (develop, #552). CON-LOCK-03 asserts the name too. The calendar-backed rows run against the Microsoft 365 sandbox tenant the stack can now be seeded with (develop, e2e/calendar-tenant), and skip without it. calendar.seed.ts owns the one room with a real mailbox and the events the specs put on it; the fixtures gain the calendar identity, an admin whose address is a mailbox there, because staff-api only lets a user host for themselves. CON-DAY-02/03/04, CON-STAFF-01/02 and CON-REP-02 are written; CON-DAY-05 is not yet, and CON-DAY-06/07 wait on the approvals driver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The concierge locker bookings listing showed
asset-KpaBMkGOPRin its Locker column where it should say "E2E Locker 0" (CON-B3 on #497). A booking stores only the locker's id: staff-api's Booking model hasasset_idandasset_idsand no name column, so theasset_namethe app sends on create never comes back.The listing now resolves the name from the lockers the state has already loaded for the building (
lockerNameinlocker-bookings.component.ts), the way the desk listing resolves desk names from metadata, and falls back to the id for a locker it does not know.Verified
bunx nx test concierge: 1330 pass, with a new case for the resolution and both fallbacks.concierge-lockers.spec.tspasses with CON-B3 lifted on test(e2e): workplace and concierge [2026-09-18] #497 (the row names the locker) and CON-LOCK-03 now asserting the name rather than the id.