Fix 30-second shutdown delay on Folia - #978
Open
Linwendong83 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With entity spawn tracking enabled, shutting down a Luminol server consistently took an extra 30 seconds. The logs pointed to
queueLoadedLocationsForShutdown(), which timed out before the database queue finished draining about a second later.Folia stops region ticking before disabling plugins. The entity scheduler can still accept a task at that point, but it won't get another tick to run it. CoreProtect then waits for the full 30-second timeout.
The shutdown thread already has permission to access these entities through Folia's ownership check. This change checks that first and saves the current location directly when allowed. Entities owned by another thread still use the existing scheduler path.