Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The shared transaction helper waited for a receipt but never checked its status. Reverted approvals and CTF operations could therefore print normal success output even though no state change occurred.
Approach
After obtaining the mined receipt, the shared proxy call helper checks its execution status before returning success. Existing callers already propagate helper errors, so they no longer reach their success output for reverted transactions.
Tests
cargo +1.91.1 fmt --checkcargo +1.91.1 clippy --locked --all-targets -- -D warningsgit diff --checkRisk
Low. Successful transactions retain the existing return shape. Only receipts that explicitly report failed execution now return an error.
Fixes #95
Note
Low Risk
Behavior change only for failed on-chain execution; successful transactions are unchanged and errors already propagate to CLI callers.
Overview
proxy::send_callnow treats mined receipts with failed execution (status0) as errors instead of returning success with a tx hash and block number. Successful txs still return the same(B256, u64)pair afterensure!(receipt.status(), ...).Callers that use this helper for approvals and CTF flows will surface revert failures instead of printing normal success when on-chain execution failed.
Adds a loopback mock JSON-RPC server and a
tokiotest that drives the real provider path viaPOLYMARKET_RPC_URL, covering both reverted and successful receipts.Reviewed by Cursor Bugbot for commit f6073ef. Bugbot is set up for automated code reviews on this repo. Configure here.