Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POLYMARKET_GEOBLOCK_HOSTendpoint overrideProblem
POLYMARKET_CLOB_HOSTconfigured normal CLOB traffic, butclob geoblockcontinued using the hard-coded production geoblock endpoint. Fully local and staging environments could not isolate all CLOB-related requests.Approach
The CLOB client configuration now reads an optional geoblock host independently from the main CLOB host. If the environment variable is absent, the SDK's existing production default remains unchanged.
Tests
GET /api/geoblockreaches the configured local hostcargo +1.91.1 fmt --checkcargo +1.91.1 clippy --locked --all-targets -- -D warningsgit diff --checkRisk
Low. Default production behavior is unchanged; the new path is opt-in through an environment variable.
Fixes #97
Note
Low Risk
Opt-in env override only; production defaults are unchanged when the variable is unset.
Overview
Adds
POLYMARKET_GEOBLOCK_HOSTso geoblock checks (e.g.clob geoblock) can target a different host than the main CLOB API. Previously onlyPOLYMARKET_CLOB_HOSTwas honored; geoblock still hit the production Polymarket URL, which blocked fully local/staging setups.CLOB client creation in
auth.rsnow builds SDK config from that env var when set; otherwise behavior stays on the SDK production default. The README documents this alongside existingPOLYMARKET_CLOB_HOSTandPOLYMARKET_RPC_URLoverrides.An integration test spins up a loopback HTTP server and asserts
clob geoblockissuesGET /api/geoblockto the configured host and returns the fixture JSON.Reviewed by Cursor Bugbot for commit 403c125. Bugbot is set up for automated code reviews on this repo. Configure here.