Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The manifest advertised Rust 1.88.0, but the committed lockfile resolves Alloy 1.7.3 packages that require Rust 1.91. Locked builds therefore failed before compilation when users followed the package metadata.
Approach
The manifest now declares the actual maximum minimum version required by the locked graph. CI installs that exact toolchain and runs
cargo check --lockedso future dependency updates cannot silently invalidate the advertised MSRV.Tests
CARGO_BUILD_JOBS=1 cargo +1.91.0 check --lockedcargo +1.91.0 fmt --checkCARGO_BUILD_JOBS=1 cargo +1.91.0 clippy --locked -- -D warningsCARGO_BUILD_JOBS=1 cargo +1.91.0 test --locked --all-targets— 82 unit and 49 integration tests passedgit diff --checkRisk
Low. This makes package metadata honest and adds verification; runtime behavior is unchanged.
Fixes #100
Note
Low Risk
Metadata and CI-only verification; no application or runtime behavior changes.
Overview
Raises the advertised MSRV from
1.88.0to1.91.0inCargo.tomlso package metadata matches what the locked dependency graph (e.g. Alloy) actually requires.Adds an
msrvCI job on Ubuntu that pins Rust1.91.0and runscargo check --locked, so MSRV regressions from lockfile updates are caught in CI. The existing stable Linux/macOScheckmatrix (fmt, clippy, test) is unchanged.Reviewed by Cursor Bugbot for commit 673ef79. Bugbot is set up for automated code reviews on this repo. Configure here.