Repository navigation
Conversation
kartojal
marked this pull request as ready for review
October 15, 2026 15:11
cesarenaldi
approved these changes
Oct 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Market identifier lookups can include open and closed results with
closed="any". Add the literal to synchronous and asynchronouslist_markets/list_eventsand their shared request builders. Preserve current defaults (None/omitted for markets,Falsefor events); invalid SDK values andanywithout a supported market identifier raise the existingUserInputErrorbefore HTTP. Existing six identifier selectors are sufficient; oracle/event selector additions remain in their separate open PRs.Contract: markets-tooling#2836. Verified the final diff/review, release v0.350.166, production promotion, live schema and safe list/keyset reads on 2026-10-15.
anyremoves only the closed filter; existing visibility, active/archive and protocol defaults still apply.Validation: Ruff lint/format, strict Pyright, non-integration pytest suite (3,246 passed) and
uv build; representative sync/async HTTP serialization and public typing coverage. Independent read-only SDK/API review found no blockers.Production caveat:
/events/countis advertised by the service schema but returns422 id is invalid; this SDK change uses only the functioning keyset routes.Companions: documentation, TypeScript.
Note
Low Risk
Additive query-parameter API with validation-only client changes; defaults and bool behavior are unchanged.
Overview
Adds
closed="any"on Gammalist_eventsandlist_markets(sync/async public and secure clients) so identifier lookups can return open and closed rows without changing existing defaults (Falsefor events, omitted/Nonefor markets).Introduces a shared
ClosedFiltertype (bool | "any"),_check_closedvalidation, and a client-side guard thatlist_markets(closed="any")must include at least one supported identifier (ids,slug,clob_token_ids, etc.); invalid values still raiseUserInputErrorbefore HTTP. Docstrings and unit tests cover param serialization, the identifier rule, and typing.Reviewed by Cursor Bugbot for commit 71d6d56. Bugbot is set up for automated code reviews on this repo. Configure here.