Repository navigation
Conversation
kartojal
marked this pull request as ready for review
October 26, 2026 13:16
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7f977c5. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

User subscriptions now deliver
auto_redeemandcombo_auto_redeemevents alongside orders and trades. The returned models expose wallet, transaction hash, condition, amount, timestamp, and combination-specific token details. Market filters match the event's condition consistently across event kinds.Validation: 68 focused user-stream tests passed; Pyright, Ruff lint, and format checks passed. The regression mixes both redemption kinds, valid order/trade neighbors, unknown frames, and malformed payloads.
Note
Medium Risk
Changes user-stream filtering and adds new parsed event shapes; wrong matcher logic could hide redemptions or leak events across markets, but scope is limited to stream models and tests.
Overview
Extends the CLOB user WebSocket event union with
auto_redeemandcombo_auto_redeem, including typed payloads (wallet, txn hash, amount, timestamp, and combo-specificposition_id/outcome_index/legs). Those types are re-exported frompolymarket.streams.Market filtering in
matcher_fornow keys offcondition_idfor all delivered events (notmarket), with combo redemptions matched via normalized combo condition IDs from subscribed market strings. Unknown wire frames and bad redemption amounts still drop during batch parse.Unit and integration tests cover parsing, discriminated-union metadata, matcher behavior, and end-to-end delivery through
UserSpecsubscriptions.Reviewed by Cursor Bugbot for commit 7f75aa9. Bugbot is set up for automated code reviews on this repo. Configure here.