Skip to content

chore: ask before changing repository skills - #2617

Open
rasdani wants to merge 2 commits into
PrimeIntellect-ai:mainfrom
rasdani:chore/skill-change-approval
Open

rasdani wants to merge 2 commits into
PrimeIntellect-ai:mainfrom
rasdani:chore/skill-change-approval

Conversation

@rasdani

@rasdani rasdani commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Require agents to suggest specific repository skill changes, explain the benefit, and wait for user approval before editing. Existing explicit requests or approvals remain sufficient; ordinary code, workflow, documentation, and PR requests do not authorize skill changes. Reading and following skills remains allowed.

Changes only AGENTS.md, using the same approval guidance as PrimeIntellect-ai/prime-envs#814. Remove skills from the generic documentation-change exception so their edits consistently require approval.

Validation: git diff --check, Markdown lint, and pre-push hooks (Ruff check/format and ty) passed.

Note

Require user approval before changing repository skills in AGENTS.md

Adds policy guidance to AGENTS.md requiring agents to suggest a specific skill update, explain its value, and get user approval before creating, modifying, renaming, or deleting skills or their supporting files and symlinks. Explicitly requested or previously approved changes may proceed without another approval; ordinary code or PR requests do not implicitly authorize skill changes.

Macroscope summarized b3de58f.


Note

Low Risk
Documentation-only change to agent behavior guidelines; no runtime or application code affected.

Overview
Adds Skills policy to AGENTS.md: agents must propose a concrete skill change, explain the benefit, and wait for user approval before creating, editing, renaming, or deleting anything under skills/ (including supporting files and symlinks).

Explicit user requests or prior approvals still count; routine asks (code fixes, docs, workflows, opening PRs) do not grant permission to touch skills. Reading and following bundled skills stays unchanged.

Reviewed by Cursor Bugbot for commit b3de58f. Bugbot is set up for automated code reviews on this repo. Configure here.

@rasdani
rasdani marked this pull request as ready for review September 17, 2026 02:49
@rasdani
rasdani marked this pull request as draft September 17, 2026 02:51
samsja
samsja previously approved these changes Sep 17, 2026
Comment thread AGENTS.md Outdated
## Docs

- **Kept intentionally minimal**: `docs/`, `skills/`, and `configs/` are deliberately sparse. Don't touch them unless your change breaks their assumptions.
- **Kept intentionally minimal**: `docs/` and `configs/` are deliberately sparse. Don't touch them unless your change breaks their assumptions.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change? this has prob prevented excessive changes before

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex revert this line

@rasdani

rasdani commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

@codex revert the line mika flagged

Comment thread AGENTS.md Outdated
@rasdani
rasdani marked this pull request as ready for review September 17, 2026 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants