Repository navigation
fix(web): guard malformed source title fields - #860
Merged
ProdigyV21 merged 4 commits intoNov 6, 2026
Merged
Conversation
petomalik6-duda
commented
Nov 2, 2026
petomalik6-duda
left a comment
petomalik6-duda
left a comment
Contributor
Author
There was a problem hiding this comment.
Patch is limited to runtime type guards in sourceTitle plus regression coverage for malformed provider payloads. The two GitHub Actions workflows currently show action_required because this PR originates from a fork; no jobs were started yet.
Owner
|
Thanks for your work, I will look into this tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #856.
Summary
ARVIO Web could crash the entire Details/Sources screen when a provider returned runtime values that did not match the TypeScript declaration, e.g. a non-string
behaviorHints.filenameordescription.The observed crash was:
TypeError: t.trim is not a functionThis PR:
behaviorHints.filenamebefore calling.trim()descriptionvalues instead of calling.split()on themsource/addonNameThe change is intentionally small and limited to source-title presentation hardening so one malformed source cannot take down the whole Sources screen.