Repository navigation
fix: scope room navigation actions to owning panes - #331
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cached room panes can consume navigation actions emitted by another pane, including another pane showing the same room. Bind thread and search-result actions to their owning pane and accept room controls only from explicit local widget IDs. This keeps opening a thread, search, or room details scoped to the pane the user operated.
Validation:
The same ownership source was exercised in the preceding local Docker Palpo / Studio / Computer Use run, including returning between rooms and expanding the final thread. That combined run used the newer Makepad dev dependency; this isolated repair keeps the current main dependency. A new combined GUI regression is tracked separately.
Remote CI: all 13 checks passed on
a00f04267e49b1bc18f9bdd29cea73f0e5a5b66a, including Linux, Windows, macOS, iOS and Android builds.