Skip to content

fix: scope room navigation actions to owning panes - #331

Merged
ZhangHanDong merged 1 commit into
mainfrom
fix/e2e-room-action-ownership
Sep 11, 2026
Merged

ZhangHanDong merged 1 commit into
mainfrom
fix/e2e-room-action-ownership

Conversation

@ZhangHanDong

@ZhangHanDong ZhangHanDong commented Sep 9, 2026 •

Copy link
Copy Markdown

Cached room panes can consume navigation actions emitted by another pane, including another pane showing the same room. Bind thread and search-result actions to their owning pane and accept room controls only from explicit local widget IDs. This keeps opening a thread, search, or room details scoped to the pane the user operated.

Validation:

  • Four ownership example/property tests passed; the release workspace suite passed 711 tests with five existing ignored tests.
  • The release app build, release workspace Clippy, static UX gate, typos, and Cargo patch guard passed. The full spec guard passed; the active ownership contract passed 5/5 checks and the encryption capability passed 7/7, with no skips or uncertain results in either. Existing manual scenarios in other contracts retain their normal manual status.
  • Independent review found no source/spec issues. No new strings, layout, dependencies, or Matrix request paths.

The same ownership source was exercised in the preceding local Docker Palpo / Studio / Computer Use run, including returning between rooms and expanding the final thread. That combined run used the newer Makepad dev dependency; this isolated repair keeps the current main dependency. A new combined GUI regression is tracked separately.

Remote CI: all 13 checks passed on a00f04267e49b1bc18f9bdd29cea73f0e5a5b66a, including Linux, Windows, macOS, iOS and Android builds.

@ZhangHanDong
ZhangHanDong merged commit cc62488 into main Sep 11, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant