Skip to content

Bump vulnerable npm transitive deps in vscode-extension - #262

Open
dstebila wants to merge 1 commit into
mainfrom
bump-npm-transitive-deps-js-yaml-qs-fast-uri
Open

dstebila wants to merge 1 commit into
mainfrom
bump-npm-transitive-deps-js-yaml-qs-fast-uri

Conversation

@dstebila

Copy link
Copy Markdown
Member

Resolves all 7 open Dependabot alerts (#42#48), all of which are transitive dev dependencies of vscode-extension/ pulled in through @vscode/vsce.

Package From To Alerts
fast-uri 3.1.5 3.1.8 #42 host confusion via skipped IDN canonicalization on scheme-relative references · #43 SSRF via repeated hostname percent-decoding · #45 SSRF via malformed IPv6 normalization · #46 host confusion via percent-encoded scheme normalization (high)
js-yaml 4.3.1 4.3.2 #48 maxTotalMergeKeys does not limit CPU use for empty merge sources (high)
qs 6.15.2 6.16.0 #44 array-limit bypass via bracket-key comma parsing · #47 DoS via attacker-controlled isBuffer (moderate)

qs 6.16.0 also pulls in side-channel 1.1.0 → 1.1.1 and side-channel-list 1.0.0 → 1.0.1.

Changes

  • package-lock.json: updated via npm audit fix (all bumps are within existing semver ranges).
  • package.json: raised the qs override floor from ^6.15.2 to ^6.16.0, so the override itself no longer admits the vulnerable range.

None of these packages are bundled into out/extension.js, so the shipped extension is unchanged.

Verification

  • npm audit: 0 vulnerabilities
  • npx tsc --noEmit: passes
  • npx vsce package: bundles and packages successfully (this runs secretlint, which exercises the bumped js-yaml / fast-uri)
  • npm ls --all: tree is consistent with the lockfile

🤖 Generated with Claude Code

Resolves all open Dependabot alerts by updating transitive
dependencies to patched versions via `npm audit fix`:

- fast-uri 3.1.5 -> 3.1.8 (host confusion via percent-encoded scheme
  normalization; host confusion via skipped IDN canonicalization on
  scheme-relative references; SSRF via malformed IPv6 normalization;
  SSRF via repeated hostname percent-decoding)
- js-yaml 4.3.1 -> 4.3.2 (maxTotalMergeKeys does not limit CPU use for
  empty merge sources)
- qs 6.15.2 -> 6.16.0 (DoS via attacker-controlled isBuffer; array-limit
  bypass via bracket-key comma parsing), pulling in side-channel 1.1.1
  and side-channel-list 1.0.1

The `qs` override floor in package.json is raised from ^6.15.2 to
^6.16.0 so the override itself excludes the vulnerable range. All
affected packages are dev-only (via @vscode/vsce), so the bundled
extension is unaffected. `npm audit` now reports 0 vulnerabilities;
`tsc --noEmit` and `vsce package` both still pass.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant