Skip to content

Send the DamageNPCAck packet on rejected NpcStrike attempts #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZakFahey wants to merge 1 commit into
base: general-devel
Choose a base branch
from
+10 −0
Open

Send the DamageNPCAck packet on rejected NpcStrike attempts #3318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions TShockAPI/GetDataHandlers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3386,6 +3386,16 @@ private static bool HandleProjectileNew(GetDataHandlerArgs args)
}

private static bool HandleNpcStrike(GetDataHandlerArgs args)
{
if (!HandleNpcStrikeInner(args))
return false;

// If we don't ack the damage on a rejected packet, the NPC will appear to deplete its health only for that client.
args.Player.SendData(PacketTypes.DamageNPCAck);
return true;
Comment thread
ZakFahey marked this conversation as resolved.
}

private static bool HandleNpcStrikeInner(GetDataHandlerArgs args)
{
short id = args.Data.ReadInt8();
var generation = args.Data.ReadInt8();
Expand Down
Loading