Fix device placement in expected sliced plans - #846
Open
cananoo wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #846 +/- ##
=======================================
Coverage 96.86% 96.86%
=======================================
Files 128 128
Lines 25947 25972 +25
=======================================
+ Hits 25133 25158 +25
Misses 814 814 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sliced_plansandexpected_sliced_plansparse_ot_distso sparse plans do not materialize a full distance matrixsparse_ot_distto apply per-pair weights in batch orderCloses #845
Validation
pre-commit run --files ot/sliced/_sliced_plans.py ot/utils.py test/sliced/test_sliced_plans.py test/test_utils.pypython -m compileall -q ot/sliced/_sliced_plans.py ot/utils.py test/sliced/test_sliced_plans.py test/test_utils.pyThe full test suite could not be built locally because this Windows environment does not have MSVC for POT's Cython extensions. The PyTorch regression test runs on CPU or CUDA when the backend is available in CI.