test: Fix tests for polars v2.0.0rc1 - #399
Merged
Merged
Conversation
Oliver Borchert (borchero)
requested review from
Andreas Albert (AndreasAlbertQC) and
Daniel Elsner (delsner)
as code owners
September 3, 2026 00:43
Copilot started reviewing on behalf of
Oliver Borchert (borchero)
September 3, 2026 00:43
View session
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 46 46
Lines 2590 2590
=========================================
Hits 2590 2590 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to tests, aligns with the stated CI failure cause, and the only feedback is a minor clarity nit in a new comment.
Pull request overview
Adjusts schema validation tests to remain stable under Polars v2’s default streaming engine behavior, by forcing in-memory collection where deterministic example-count assertions are required.
Changes:
- Extend the
_validate_and_collecttest helper to allow selecting aLazyFrame.collectengine. - Force
engine="in-memory"for the primary key example-count assertion test to avoid streaming “fail fast” behavior affecting row counts.
File summaries
| File | Description |
|---|---|
| tests/schema/test_validate.py | Adds an engine override for LazyFrame.collect in tests and applies it to stabilize a streaming-sensitive assertion. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Andreas Albert (AndreasAlbertQC)
approved these changes
Sep 3, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Nightly CI fails as polars v2 makes the streaming engine the default. Interestingly, we don't need to change a lot for this (arguably massive) change 👀