Conversation
The heading was assembled in the template as "{failing} failing and {successful}
successful check(s)", which has no place for a warning: a run with 1 FAIL, 1 WARN
and 1 PASS announced two of its three rows. It reads "1 failing, 1 warning and 1
successful check", built in the view model where the join and the plural are
readable. An outcome nothing concluded is left out rather than counted as a zero.
Site's platform renders this same comment for repositories on its ingest path,
and both post onto one pull request, so the two headings match again (Site
#4201). Not identically: Site appends "· N not run", which this summary has no
field for, and the heading's doc comment says so rather than claiming parity.
There was a problem hiding this comment.

Query Doctor — 6 successful checks
More details via MCP → get_ci_run({ runId: "01a0a344-156f-7bb3-87de-4fc4a48d5783" }) · view run · docs
3 queries read against main on assumed statistics of 10,000,000 rows per table. Sync production stats for costs measured against your real data.
Member
Author
|
Closing: the fat action is being deprecated, so its renderer is not worth fixing. The platform's half is Query-Doctor/Site#4311. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
A developer reads one Query Doctor comment on their pull request. Two renderers produce it: this template, for repositories on the fat action, and Site's platform, for repositories on the ingest path. A repository running both legs gets both comments on the same pull request, so a difference between them is visible side by side.
This PR brings the two into line. Site's half is Query-Doctor/Site#4311.
What
On a run carrying a warning the heading read
1 failing and 1 successful check: two of three rows announced. It now reads1 failing, 1 warning and 1 successful check. An outcome nothing concluded is left out rather than counted as a zero.How
The sentence moved out of the template into the view model, where the join and the plural are readable.
success.md.j2renders{{ gateHeading }};github.tsbuilds it.formatGateHeadingis a hand-maintained copy ofheadingin Site'sapps/api/src/ci/capture/capture-comment.ts. Sharing it would mean putting it in@query-doctor/corebesidesummarizeGates, which this repository consumes from npm and cannot adopt in the change that ships Site's half. The two are not identical either: Site appends· N not runfrom anunevaluatedcount, and thesummarizeGatesinsrc/gate/evaluate.tshas no such field. The doc comment says both rather than claiming parity.Tests
github.test.tscovers the warning heading beside the two cases already there: nothing failing, and one failing with one passing.Its 78 tests pass and
tsc --noEmitis clean. The full suite reports four failures, insrc/sql/postgresjs.exit.test.ts,src/remote/publish-stats-on-sync.test.tsandsrc/remote/remote-controller.test.ts. All six tests in those three files pass when the files run alone, and none of them touches the reporter.