Repository navigation
Conversation
Contributor
Reviewer's GuideThe PR adds Codex packaging and documented CLI installation while adapting the shared sdlc-workflow skills to use client-appropriate AGENTS.md or CLAUDE.md project configuration without disrupting Claude Code compatibility. Sequence diagram for client-specific project configuration setupsequenceDiagram
actor User
participant Client as Claude_Code_or_Codex
participant Setup as setup_skill
participant Config as Project_configuration_file
User->>Client: $setup
Client->>Setup: Run setup
Setup->>Config: Read AGENTS.md or CLAUDE.md
Setup->>Config: Validate and update Project Configuration
Config-->>Setup: Configuration saved
Setup-->>Client: Report setup result
Client-->>User: Ready for shared sdlc-workflow skills
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
ptomanRH
marked this pull request as ready for review
October 23, 2026 11:09
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 3 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="docs/codex.md" line_range="12" />
<code_context>
+installation. Add the marketplace and install the plugin with:
+
+```bash
+codex plugin marketplace add RHEcosystemAppEng/sdlc-plugins --ref main
+codex plugin add sdlc-workflow@sdlc-plugins
+```
</code_context>
<issue_to_address>
**Codex marketplace installation cannot resolve plugin**
When a user follows the documented Codex installation steps, codex cannot register this repository as a marketplace because the repository contains only Claude Code's `.claude-plugin/marketplace.json` and no Codex marketplace registry; the following `codex plugin add sdlc-workflow@sdlc-plugins` therefore cannot resolve the plugin, so installation stops before skills load.
Add the Codex marketplace registry in the format Codex CLI expects and include the `sdlc-workflow` plugin entry.
</issue_to_address>
### Comment 2
<location path="CLAUDE.md" line_range="19" />
<code_context>
+The plugin version must be kept in sync in three files:
- [`plugins/sdlc-workflow/.claude-plugin/plugin.json`](plugins/sdlc-workflow/.claude-plugin/plugin.json) — the plugin manifest (required by CI validation)
+- [`plugins/sdlc-workflow/.codex-plugin/plugin.json`](plugins/sdlc-workflow/.codex-plugin/plugin.json) — the Codex compatibility manifest
- [`.claude-plugin/marketplace.json`](.claude-plugin/marketplace.json) — the marketplace registry (required for relative-path plugins per Claude Code docs)
</code_context>
<issue_to_address>
**Codex manifest keeps stale version**
When maintainers follow the documented version-bump procedure, the instructions say to update “both files” after listing three versioned files, so maintainers can leave the Codex manifest unchanged. Codex installations then advertise stale plugin version metadata and do not show the corresponding update.
Explicitly instruct maintainers to update all three versioned files together.
Also at `CLAUDE.md:20`.
</issue_to_address>
### Comment 3
<location path="docs/codex.md" line_range="33-34" />
<code_context>
+
+The file must contain the `# Project Configuration` sections described in
+[`project-config-contract.md`](project-config-contract.md). The configuration
+format is shared between both clients, so teams can keep one file when both
+clients are used.
+
+Run the setup skill after installing the plugin and choose the configuration
</code_context>
<issue_to_address>
**One config file misses a client**
When a team uses both clients but keeps Project Configuration in only one of the two filenames, claude Code reads `CLAUDE.md` while Codex prefers `AGENTS.md`, and the setup instructions update the current client's file and synchronize both only on explicit request. A team that keeps only one file therefore leaves one client's Project Configuration unavailable.
Clarify that both clients need their respective configuration files unless a documented mechanism makes one file available to both.
</issue_to_address>Sourcery assessment
Needs a human reviewer. 3 findings to address first, and if Codex selects or interprets project configuration differently than intended, a workflow could use incorrect Jira settings or write incorrect Jira records; those changes can remain after the plugin is reverted and require manual correction. The impact is bounded to the affected configuration or records.
Blocking findings: docs/codex.md:12, CLAUDE.md:19, docs/codex.md:34
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Native Fullsend Eval Results
Head: 08de91e
Merge: 16dd626
Trusted workflow: ec68eec
Reviewed eval source: ec68eec
Native job: success; complete: true.
Execution evidence: valid; quality score (advisory): 27/28 passed.
| Case | Execution evidence | Quality score (advisory) |
|---|---|---|
| 033-absent | valid | 4/4 |
| 034-empty | valid | 5/5 |
| 035-malformed | valid | 4/5 |
| 036-valid | valid | 7/7 |
| 037-release | valid | 7/7 |
Contributor
There was a problem hiding this comment.
Native Fullsend Eval Results
Head: 8126825
Merge: f9d598e
Trusted workflow: ec68eec
Reviewed eval source: ec68eec
Native job: success; complete: true.
Execution evidence: valid; quality score (advisory): 26/28 passed.
| Case | Execution evidence | Quality score (advisory) |
|---|---|---|
| 033-absent | valid | 4/4 |
| 034-empty | valid | 4/5 |
| 035-malformed | valid | 4/5 |
| 036-valid | valid | 7/7 |
| 037-release | valid | 7/7 |
Contributor
Author
|
not needed, use Codex plugin app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to TC-6134. Adds Codex packaging, AGENTS.md support, documentation, and preserves Claude Code compatibility.
Summary by Sourcery
Enable the sdlc-workflow plugin to run through Codex while preserving existing Claude Code support.
New Features:
Enhancements:
Documentation: